Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution Guidelines #123

Merged
merged 8 commits into from
Jul 5, 2024
Merged

Contribution Guidelines #123

merged 8 commits into from
Jul 5, 2024

Conversation

chrisgurney
Copy link
Contributor

Proposal for a set of contribution guidelines and instructions for things.py

@chrisgurney
Copy link
Contributor Author

chrisgurney commented Jun 27, 2024

@mikez @AlexanderWillner Ready for review! Of course, feel free to do with this what you wish!

Here it is with the markup, so it's easier to review the formatting:
https://github.com/chrisgurney/things.py/blob/main/CONTRIBUTING.md

@mikez
Copy link
Contributor

mikez commented Jun 27, 2024

@chrisgurney Looks great to me! 🥳

@AlexanderWillner What do you think?

@AlexanderWillner
Copy link
Contributor

@AlexanderWillner What do you think?

Thanks a lot! Do you think we should add a warning to the section "Copy the test database to your Things app folder"? As this would overwrite your "production database" (i.e., your current database you're working with in Things.app)

@chrisgurney
Copy link
Contributor Author

chrisgurney commented Jul 3, 2024

@AlexanderWillner

Thanks a lot! Do you think we should add a warning to the section "Copy the test database to your Things app folder"? As this would overwrite your "production database" (i.e., your current database you're working with in Things.app)

Good idea. I've added a warning in step 2 to make sure they've actually done step 1. 😀

⚠️ Before you proceed, make sure you've actually backed up your own personal database per step 1.

https://github.com/chrisgurney/things.py/blob/main/CONTRIBUTING.md

@AlexanderWillner
Copy link
Contributor

Thanks, lgtm!

@mikez
Copy link
Contributor

mikez commented Jul 5, 2024

@chrisgurney I did some light editing for readability. Especially, I moved the instructions on how to edit the things database to the end, as in many cases this is not needed. Also, removed Windows-specific comments.

Do you think these edits make sense? Otherwise lgtm.

@chrisgurney
Copy link
Contributor Author

@mikez Makes sense to me!

@mikez mikez merged commit f629247 into thingsapi:main Jul 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants