-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution Guidelines #123
Conversation
@mikez @AlexanderWillner Ready for review! Of course, feel free to do with this what you wish! Here it is with the markup, so it's easier to review the formatting: |
@chrisgurney Looks great to me! 🥳 @AlexanderWillner What do you think? |
Thanks a lot! Do you think we should add a warning to the section "Copy the test database to your Things app folder"? As this would overwrite your "production database" (i.e., your current database you're working with in Things.app) |
Good idea. I've added a warning in step 2 to make sure they've actually done step 1. 😀
https://github.com/chrisgurney/things.py/blob/main/CONTRIBUTING.md |
Thanks, lgtm! |
@chrisgurney I did some light editing for readability. Especially, I moved the instructions on how to edit the things database to the end, as in many cases this is not needed. Also, removed Windows-specific comments. Do you think these edits make sense? Otherwise lgtm. |
@mikez Makes sense to me! |
Proposal for a set of contribution guidelines and instructions for things.py