fix: Use one database connection rather than one per query #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbhutton
changed the title
mbhutton
changed the title
mbhutton
force-pushed
the
main
branch
3 times, most recently
from
7a91d5e to
11de118
Compare
Each query creates a new DB connection. This change is to close each new connection rather than leaving them open, to allow for runs which involve large numbers of queries.
Use one connection for the lifetime of the process rather than creating a new connection for each query. This cuts execution time roughtly in half for queries across large Things databases.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is staged as 2 commits, with the first being a bug fix, and the second being a suggested performance improvement:
This is to address #125
The first change is to allow queries such as
things-cli todoson a DB with 2500 tasks.The second change is to speed up such queries, reducing execution time from ~0.230 seconds to ~0.120 seconds.