-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exact date query to enable logyesterday #96
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@bkleinen Thank you for the pull request and patience. :) My comments here relate to the files in I like the proposal, and want to offer a slight tweak. Instead of doing
Without the comparator-prefix, the defaults could then always be ">=":
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
start_date, stop_date, and deadline parameters now allow to pass ISO 8601 dates with an optional operator. The input is converted to a "Things date" integer prior to running the SQL statement if it such a date column; otherwise regular UNIX Time is used. Examples: '2023-05-22' '<=2023-05-22' '>2023-05-22' In SQL, depending on its column type, the parameter '<2023-05-22' is converted into deadline < 132602624 or date(stopDate, 'unixepoch') < date('2023-05-22') See also: #96 and thingsapi/things-cli#9
Follow-up: Implemented this syntax but chose no operator to mean exact match, so |
to be able to cleanly implement thingsapi/things-cli#9 an exact date match is needed in the api.