Skip to content

Commit

Permalink
Rename stuff to new names once again
Browse files Browse the repository at this point in the history
  • Loading branch information
fingolfin committed Nov 22, 2023
1 parent 0003169 commit 1478170
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions src/EllCrv/Finite.jl
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,7 @@ julia> order(E)
100
```
"""
@attr fmpz function order(E::EllCrv{T}) where T<:FinFieldElem
@attr ZZRingElem function order(E::EllCrv{T}) where T<:FinFieldElem
R = base_field(E)
p = characteristic(R)
q = order(R)
Expand All @@ -859,7 +859,7 @@ end
function _order_factored(E::EllCrv{<:FinFieldElem})
return get_attribute!(E, :order_factored) do
return factor(order(E))
end::Fac{fmpz}
end::Fac{ZZRingElem}
end

@doc raw"""
Expand Down Expand Up @@ -1095,7 +1095,7 @@ end
# DOI: 10.1007/s00145-004-0315-8
#
#
@attr Tuple{Vector{fmpz}, Vector{EllCrvPt{T}}} function _grp_struct_with_gens(E::EllCrv{T}) where {T <: FinFieldElem}
@attr Tuple{Vector{ZZRingElem}, Vector{EllCrvPt{T}}} function _grp_struct_with_gens(E::EllCrv{T}) where {T <: FinFieldElem}
N = order(E)
K = base_field(E)
# TODO:
Expand Down Expand Up @@ -1187,7 +1187,7 @@ GrpAb: Z/2 x Z/5200
function abelian_group(E::EllCrv{U}) where {U <: FinFieldElem}
_invdiv, _gens = _grp_struct_with_gens(E)
if length(_gens) == 0
strct = fmpz[]
strct = ZZRingElem[]
gens = elem_type(E)[]
elseif length(_gens) == 1
strct = copy(_invdiv)
Expand Down
2 changes: 1 addition & 1 deletion src/LocalField/neq.jl
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ end
########### any_root computes a single root in the finite field extensions####

import Nemo: any_root
function any_root(F::Union{fqPolyRepField, Hecke.RelFinField, FqField}, f::PolyElem)
function any_root(F::Union{fqPolyRepField, Hecke.RelFinField, FqField}, f::PolyRingElem)
g = change_base_ring(F, f; cached = false)
return any_root(g)
end
Expand Down
4 changes: 2 additions & 2 deletions src/QuadForm/Torsion.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2207,7 +2207,7 @@ end
################################################################################

@doc raw"""
submodules(T::TorQuadMod; kw...)
submodules(T::TorQuadModule; kw...)
Return the submodules of `T` as an iterator. Possible keyword arguments to
restrict the submodules:
Expand All @@ -2224,7 +2224,7 @@ function submodules(T::TorQuadModule; kw...)
end

@doc raw"""
stable_submodules(T::TorQuadMod, act::Vector{TorQuadModuleMor}; kw...)
stable_submodules(T::TorQuadModule, act::Vector{TorQuadModuleMor}; kw...)
Return the submodules of `T` stable under the endomorphisms in `act` as
an iterator. Possible keyword arguments to restrict the submodules:
Expand Down
2 changes: 1 addition & 1 deletion test/NumFieldOrd/NumFieldOrd.jl
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ end
@test Order(K, [1]) == equation_order(K)
@test Order(K, []) == equation_order(K)

K, a = NumberField(x^4 - 10*x^2 + 1, "a")
K, a = number_field(x^4 - 10*x^2 + 1, "a")
x = 1//2*a^3 - 9//2*a # sqrt(2)
y = 1//2*a^3 - 11//2*a # sqrt(3)
O = Order(K, [x, y, x*y])
Expand Down
2 changes: 1 addition & 1 deletion test/QuadForm/Quad/Spaces.jl
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
w = QQ[1 1;]
p = @inferred inner_product(q, v, w)
@test p == v * gram_matrix(q) * transpose(w)
for T in [Int, BigInt, fmpz, Rational{BigInt}, Rational{Int}]
for T in [Int, BigInt, ZZRingElem, Rational{BigInt}, Rational{Int}]
@test inner_product(q, [1, 1], [1, 2]) == 3
end

Expand Down

0 comments on commit 1478170

Please sign in to comment.