Change residue_field for local fields #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thofma
commented
Oct 31, 2023
| @@ -796,6 +798,7 @@ function local_fundamental_class_serre(mKL::LocalFieldMor) | |||
| rE, mE = residue_field(E) | |||
| rL, mL = residue_field(L) | |||
| rK, mK = residue_field(K) | |||
| # how is this supposed to work? | |||
| mrKL = hom(rK, rL, mL(mKL(preimage(mK, gen(rK))))) | |||
There was a problem hiding this comment.
Without promotion magic, this only works if base_field(rK) === base_field(rL), but this is not the case here.
thofma
force-pushed
the
th/localocal
branch
3 times, most recently
from
60751a5 to
0324987
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1268 +/- ##
==========================================
+ Coverage 74.49% 74.62% +0.13%
==========================================
Files 346 346
Lines 111320 111378 +58
==========================================
+ Hits 82925 83121 +196
+ Misses 28395 28257 -138
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to compute$p$ -adic regulators for large $p$ . This cannot work with the current design, so we change
residue_fieldto use the "new" finite fields.There is one remaining issue in the computation of the fundamental class. @fieker let's talk about this on Thursday.