Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use terse and is_terse from AbstractAlgebra #1469

Merged
merged 6 commits into from
May 1, 2024

Conversation

fingolfin
Copy link
Contributor

This requires a new AA release

@thofma thofma marked this pull request as ready for review April 30, 2024 21:51
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 63.23529% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 75.18%. Comparing base (1efdecf) to head (8a79454).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
- Coverage   75.21%   75.18%   -0.03%     
==========================================
  Files         354      354              
  Lines      112712   112708       -4     
==========================================
- Hits        84771    84745      -26     
- Misses      27941    27963      +22     
Files Coverage Δ
src/GrpAb/Elem.jl 96.40% <100.00%> (ø)
src/Hecke.jl 42.59% <ø> (ø)
src/Misc/MSet.jl 96.23% <100.00%> (ø)
src/NumField/ComplexEmbeddings/NfAbs.jl 87.12% <100.00%> (ø)
src/NumField/ComplexEmbeddings/NfAbsNS.jl 99.37% <100.00%> (ø)
src/NumField/ComplexEmbeddings/NfRel.jl 98.47% <100.00%> (ø)
src/NumField/ComplexEmbeddings/QQ.jl 92.00% <100.00%> (ø)
src/NumField/NfAbs/NfAbs.jl 68.33% <100.00%> (ø)
src/NumField/NfAbs/NonSimple.jl 81.97% <100.00%> (+0.14%) ⬆️
src/NumField/NfRel/NfRel.jl 79.00% <100.00%> (ø)
... and 19 more

... and 28 files with indirect coverage changes

@thofma thofma enabled auto-merge (squash) May 1, 2024 09:30
@thofma thofma merged commit 3ed50fd into thofma:master May 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants