Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat of AA and Nemo #1703

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Conversation

lgoettgens
Copy link
Contributor

No description provided.

@lgoettgens lgoettgens closed this Dec 13, 2024
@lgoettgens lgoettgens reopened this Dec 13, 2024
@lgoettgens
Copy link
Contributor Author

The failure in Run long tests is due to an old version of GAP.jl getting used here, as the current release is not compatible with the new AA yet (waiting for backport of oscar-system/GAP.jl#1091 to the 0.12.x release series). We should just wait for that right now and then restart the test.

@lgoettgens lgoettgens closed this Dec 14, 2024
@lgoettgens lgoettgens reopened this Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.91%. Comparing base (3627d1f) to head (98476ac).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/NumField/NfAbs/MultDep.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
- Coverage   75.98%   75.91%   -0.08%     
==========================================
  Files         362      362              
  Lines      114363   114366       +3     
==========================================
- Hits        86898    86819      -79     
- Misses      27465    27547      +82     
Files with missing lines Coverage Δ
src/NumField/NfAbs/MultDep.jl 68.15% <90.00%> (ø)

... and 31 files with indirect coverage changes

@lgoettgens
Copy link
Contributor Author

@thofma CI is happy now that the new GAP.jl is released.

@thofma thofma merged commit e905f2d into thofma:master Dec 15, 2024
31 of 32 checks passed
@lgoettgens lgoettgens deleted the lg/bump-Nemo-0.48 branch December 15, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants