-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): support multi-scene applications #13941
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
changed the title
feat: support multi-scene applications
feat(ios): support multi-scene applications
Oct 31, 2023
@janvennemann ping |
janvennemann
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! As per discussion with Hans there are no additional backwards compatibility fixes required and existing app work perfectly fine with this change, so this is good to go.
hansemannn
added a commit
that referenced
this pull request
Jan 20, 2024
This reverts commit bfc87a6.
hansemannn
added a commit
to hansemannn/titanium_mobile
that referenced
this pull request
Jan 30, 2024
)"" This reverts commit 4a1d20f.
hansemannn
added a commit
that referenced
this pull request
Jan 30, 2024
hansemannn
added a commit
that referenced
this pull request
Jan 31, 2024
hansemannn
added a commit
that referenced
this pull request
May 26, 2024
This reverts commit bfc87a6. Revert "fix(ios): fix debug issues with scenes (#13979)" This reverts commit 8bcd5c3. Revert "fix(ios): fix various issues related to the scene migration (#13981)" This reverts commit 6e40edb. Revert "fix(ios): restore compatibility for Ti.App._resumeRestart() (#13989)" This reverts commit 3a44b3d. Revert "fix(ios): fix some open issues related to scenes (#14020)" This reverts commit a0a3aea. chore: restore start sequence
hansemannn
added a commit
that referenced
this pull request
May 26, 2024
This reverts commit bfc87a6. Revert "fix(ios): fix debug issues with scenes (#13979)" This reverts commit 8bcd5c3. Revert "fix(ios): fix various issues related to the scene migration (#13981)" This reverts commit 6e40edb. Revert "fix(ios): restore compatibility for Ti.App._resumeRestart() (#13989)" This reverts commit 3a44b3d. Revert "fix(ios): fix some open issues related to scenes (#14020)" This reverts commit a0a3aea. chore: restore start sequence # Conflicts: # iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.h # iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
hansemannn
added a commit
to hansemannn/titanium_mobile
that referenced
this pull request
Oct 1, 2024
hansemannn
added a commit
to hansemannn/titanium_mobile
that referenced
this pull request
Oct 2, 2024
This reverts commit 7904769.
hansemannn
added a commit
to hansemannn/titanium_mobile
that referenced
this pull request
Oct 2, 2024
* feat: support multi-scene applications * fix: add keys to template Info.plist to restore backwards compatibility # Conflicts: # iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.h # iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the base compatibility for multi-scene apps, e.g. for iPadOS, CarPlay and visionOS. I may also add a PoC of defining scene-specific windows on the JS-side as well, but that's a whole different effort. Todos: