Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add info about iOS foreground notifications #13956

Merged
merged 3 commits into from
Jan 30, 2024
Merged

docs: add info about iOS foreground notifications #13956

merged 3 commits into from
Jan 30, 2024

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Dec 19, 2023

Apparently there is a showInForground in userInfo:

titanium-sdk/iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m

Line 547 in abdc7bf

BOOL showInForeground = [TiUtils boolValue:notification.request.content.userInfo[@"showInForeground"] def:NO];
but it was never documented.

Setting userInfo: {showInForeground:true} will display a local notification banner if the app is in foreground.

hansemannn
hansemannn requested changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick ones

apidoc/Titanium/App/iOS/UserNotificationCenter.yml Outdated Show resolved Hide resolved
apidoc/Titanium/App/iOS/UserNotificationCenter.yml Outdated Show resolved Hide resolved
@m1ga m1ga added the docs label Jan 30, 2024
cb1kenobi
cb1kenobi approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cb1kenobi cb1kenobi merged commit 4e5ca53 into master Jan 30, 2024
7 checks passed
@cb1kenobi cb1kenobi deleted the 231219_ios_docs branch January 30, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

@cb1kenobi cb1kenobi cb1kenobi approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m1ga @cb1kenobi @hansemannn