Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): more log output #13999

Merged
merged 8 commits into from
Sep 16, 2024
Merged

feat(android): more log output #13999

merged 8 commits into from
Sep 16, 2024

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Feb 29, 2024

current log length it 4059. This PR will split up long logs and outputs them in chunks.

Test

Ti.API.info("something long");
console.log("somenthing long");

Use https://www.blindtextgenerator.com/lorem-ipsum to generate a long string

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hansemannn hansemannn merged commit 322b09b into master Sep 16, 2024
6 checks passed
hansemannn pushed a commit that referenced this pull request Sep 16, 2024
* feat(android): more log output

* remove if

* change for loop

* Update android/runtime/v8/src/native/modules/APIModule.cpp

Co-authored-by: Chris Barber <[email protected]>

---------

Co-authored-by: Chris Barber <[email protected]>
@m1ga m1ga deleted the androidLogLen branch September 16, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants