transition to lifecycle for deprecations (#531)

* use lifecycle

* hard-deprecate `p_value()` and `conf_int()`

* transition `.Deprecated` to `lifecycle::deprecate_warn()`

DESCRIPTION

@@ -42,6 +42,7 @@ Imports:
     ggplot2,
     glue (>= 1.3.0),
     grDevices,
+    lifecycle,
     magrittr,
     methods,
     patchwork,
@@ -67,5 +68,5 @@ Config/Needs/website: tidyverse/tidytemplate
 Encoding: UTF-8
 LazyData: true
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.0
+RoxygenNote: 7.3.1
 Config/testthat/edition: 3

NEWS.md

@@ -1,5 +1,8 @@
 # infer (development version)
 
+* The aliases `p_value()` and `conf_int()`, first deprecated 6 years ago, now
+  return an error (#530).
+
 # infer v1.0.6
 
 * Updated infrastructure for errors, warnings, and messages (#513). Most of these changes will not be visible to users, though:

R/deprecated.R

@@ -17,16 +17,12 @@ NULL
 #' @export
 conf_int <- function(x, level = 0.95, type = "percentile",
   point_estimate = NULL) {
-  .Deprecated("get_confidence_interval")
-  get_confidence_interval(
-    x, level = level, type = type, point_estimate = point_estimate
-  )
+  lifecycle::deprecate_stop("0.4.0", "conf_int()", "get_confidence_interval()")
 }
 
 
 #' @rdname deprecated
 #' @export
 p_value <- function(x, obs_stat, direction) {
-  .Deprecated("get_p_value")
-  get_p_value(x = x, obs_stat = obs_stat, direction = direction)
+   lifecycle::deprecate_stop("0.4.0", "conf_int()", "get_p_value()")
 }

R/wrappers.R

@@ -150,10 +150,10 @@ t_stat <- function(x, formula,
                    conf_int = FALSE,
                    conf_level = 0.95,
                    ...) {
-  .Deprecated(
-    new = "observe",
-    msg = c("The t_stat() wrapper has been deprecated in favor of the more " ,
-            "general observe(). Please use that function instead.")
+  lifecycle::deprecate_warn(
+    when = "1.0.0",
+    what = "t_stat()",
+    with = "observe()"
   )
 
   check_conf_level(conf_level)
@@ -298,11 +298,11 @@ chisq_test <- function(x, formula, response = NULL,
 #' @export
 chisq_stat <- function(x, formula, response = NULL,
                        explanatory = NULL, ...) {
-  .Deprecated(
-    new = "observe",
-    msg = c("The chisq_stat() wrapper has been deprecated in favor of the ",
-            "more general observe(). Please use that function instead.")
-  )
+   lifecycle::deprecate_warn(
+     when = "1.0.0",
+     what = "chisq_stat()",
+     with = "observe()"
+   )
 
   # Parse response and explanatory variables
   response    <- enquo(response)

tests/testthat/_snaps/aliases.md

@@ -1,20 +1,18 @@
-# old aliases produce warning
+# old aliases produce informative error
 
     Code
-      res <- gss_calc %>% p_value(obs_stat = -0.2, direction = "right") %>% dplyr::pull()
+      res <- gss_calc %>% p_value(obs_stat = -0.2, direction = "right")
     Condition
-      Warning:
-      'p_value' is deprecated.
-      Use 'get_p_value' instead.
-      See help("Deprecated")
+      Error:
+      ! `conf_int()` was deprecated in infer 0.4.0 and is now defunct.
+      i Please use `get_p_value()` instead.
 
 ---
 
     Code
       res_ <- gss_permute %>% conf_int()
     Condition
-      Warning:
-      'conf_int' is deprecated.
-      Use 'get_confidence_interval' instead.
-      See help("Deprecated")
+      Error:
+      ! `conf_int()` was deprecated in infer 0.4.0 and is now defunct.
+      i Please use `get_confidence_interval()` instead.
 

tests/testthat/_snaps/observe.md

@@ -4,13 +4,15 @@
       res_wrap <- gss_tbl %>% chisq_stat(college ~ partyid)
     Condition
       Warning:
-      The chisq_stat() wrapper has been deprecated in favor of the more general observe(). Please use that function instead.
+      `chisq_stat()` was deprecated in infer 1.0.0.
+      i Please use `observe()` instead.
 
 ---
 
     Code
       res_wrap_2 <- gss_tbl %>% t_stat(hours ~ sex, order = c("male", "female"))
     Condition
       Warning:
-      The t_stat() wrapper has been deprecated in favor of the more general observe(). Please use that function instead.
+      `t_stat()` was deprecated in infer 1.0.0.
+      i Please use `observe()` instead.