Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce noise in devtools::test() #534

Merged
merged 2 commits into from
Mar 25, 2024
Merged

reduce noise in devtools::test() #534

merged 2 commits into from
Mar 25, 2024

Conversation

simonpcouch
Copy link
Collaborator

Closes #533—pulls expect_warning() output expectations out of expect_doppelganger() and assigns output to pass to expect_doppelganger().

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good few of these. Several snaps had 0-line svgs following a vdiffr upgrade, and were then ignored when another version of vdiffr was released triggering an automatic skip.

@simonpcouch simonpcouch merged commit 5f3e7c9 into main Mar 25, 2024
8 checks passed
@simonpcouch simonpcouch deleted the noise-533 branch March 25, 2024 17:42
Copy link

github-actions bot commented Apr 9, 2024

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce noise in devtools::test()
1 participant