Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ars548): updated the driver according to new documentation #253

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Jan 20, 2025

PR Type

  • Improvement

Related Links

Description

  • Added a frequency check on the input signals
  • Refactored radar configuration

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@knzo25 knzo25 requested a review from mojomex January 20, 2025 07:23
@knzo25 knzo25 self-assigned this Jan 20, 2025
@knzo25 knzo25 marked this pull request as draft January 20, 2025 07:24
@knzo25
Copy link
Collaborator Author

knzo25 commented Jan 20, 2025

Will open the PR once I confirm it works on the bench (need to delete some prints as well)

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 75 lines in your changes missing coverage. Please review.

Project coverage is 27.00%. Comparing base (33e77cf) to head (a22a695).

Files with missing lines Patch % Lines
...nental/continental_ars548_hw_interface_wrapper.cpp 0.00% 42 Missing ⚠️
..._hw_interfaces/continental_ars548_hw_interface.cpp 0.00% 21 Missing ⚠️
..._common/include/nebula_common/util/ring_buffer.hpp 0.00% 11 Missing ⚠️
...ontinental/decoders/continental_ars548_decoder.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   27.18%   27.00%   -0.18%     
==========================================
  Files         104      105       +1     
  Lines        9464     9527      +63     
  Branches     2326     2339      +13     
==========================================
  Hits         2573     2573              
- Misses       6455     6518      +63     
  Partials      436      436              
Flag Coverage Δ
differential 27.00% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant