Pick #3688 apiserver: move loglevel under spec #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/v1/apiserver_types.go
Outdated
| // +kubebuilder:validation:Enum=Fatal;Error;Warn;Info;Debug;Trace | ||
| // +kubebuilder:default=Info | ||
| // +optional | ||
| ApiServerLogLevel *string `json:"apiServerLogLevel,omitempty"` |
There was a problem hiding this comment.
Suggested change
| ApiServerLogLevel *string `json:"apiServerLogLevel,omitempty"` | |
| APIServerLogLevel *string `json:"apiServerLogLevel,omitempty"` |
Same-case acryonyms :D
api/v1/apiserver_types.go
Outdated
| // +optional | ||
| ApiServerLogLevel *string `json:"apiServerLogLevel,omitempty"` | ||
|
|
||
| // +kubebuilder:validation:Enum=Fatal;Error;Warn;Info;Debug;Trace |
There was a problem hiding this comment.
Do we want to define a type LogLevel string that can carry these validations / defaults rather than replicate them in both places? Not super important but might be a bit cleaner.
There was a problem hiding this comment.
I had the same thought that we should have a LogLevel type.
ti-afra
force-pushed
the
pick-log-level
branch
from
9a53897 to
fdf0603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.