Write to multiple buckets. #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By configuring the store bucket name as a list, this adds the ability to write to that list of buckets in order.
iandees
approved these changes
Nov 12, 2018
iandees
reviewed
Nov 12, 2018
tilequeue/store.py
Outdated
|
|
||
| # if buckets are given as a list, then write to each of them and read from | ||
| # the last one. this behaviour is captures in MultiStore. | ||
| if isinstance(bucket_name, list): |
There was a problem hiding this comment.
It might be good to make sure we still have a test that covers the single-string bucket case. I've been bitten a couple times before by the fact that Python considers a string an iterable and it acts as a list of characters. Your isinstance(bucket_name, list) check here will protect against that, but I could see it inadvertently getting streamlined into a iterable-ness check in the future.
There was a problem hiding this comment.
Good point - added test for that in 078c26a.
rmarianski
approved these changes
Nov 12, 2018
tilequeue/store.py
Outdated
| delete_retry_interval, logger, object_acl, tags, tile_key_gen) | ||
|
|
||
| # if buckets are given as a list, then write to each of them and read from | ||
| # the last one. this behaviour is captures in MultiStore. |
There was a problem hiding this comment.
Well spotted! Fixed in d3f8277.
… is treated like a single-item list, not by iterating over each character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By configuring the store bucket name as a list, this adds the ability to write to that list of buckets in order.
Connects to #353.