Skip to content

Commit

Permalink
[build] explicitly pass version from github workflow to rake task
Browse files Browse the repository at this point in the history
  • Loading branch information
titusfortner committed Jun 18, 2024
1 parent f09b94c commit 8a89cec
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pre-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ jobs:
# run: git reset HEAD~1
- name: Update everything including early release CDP
if: ${{ github.event.inputs.chrome_channel == 'early-stable' }}
run: ./go all:prepare['Beta']
run: ./go all:prepare[${{ github.event.inputs.version }},Beta]
- name: Update everything including released CDP
if: ${{ github.event.inputs.chrome_channel == 'stable' }}
run: ./go "all:prepare[Stable]"
run: ./go "all:prepare[${{ github.event.inputs.version }},Stable]"
- name: Create Pull Request
uses: peter-evans/create-pull-request@v6
with:
Expand Down
5 changes: 3 additions & 2 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -1078,8 +1078,9 @@ namespace :all do
end

desc 'Update everything in preparation for a release'
task :prepare, [:channel] do |_task, arguments|
task :prepare, [:version, :channel] do |_task, arguments|
chrome_channel = arguments[:channel] || 'Stable'
version = arguments[:version]
args = Array(chrome_channel) ? ['--', "--chrome_channel=#{chrome_channel.capitalize}"] : []
Bazel.execute('run', args, '//scripts:pinned_browsers')
commit!('Update pinned browser versions', ['common/repositories.bzl'])
Expand Down Expand Up @@ -1109,7 +1110,7 @@ namespace :all do
commit!('Update authors file', ['AUTHORS'])

# Note that this does not include Rust version changes that are handled in separate rake:version task
Rake::Task['all:version'].invoke
Rake::Task['all:version'].invoke(version)
commit!("FIX CHANGELOGS BEFORE MERGING!\n\nUpdate versions and change logs to release Selenium #{java_version}",
['dotnet/CHANGELOG',
'dotnet/selenium-dotnet-version.bzl',
Expand Down

0 comments on commit 8a89cec

Please sign in to comment.