Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Prepare for release of Selenium 4.22.0 #67

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

titusfortner
Copy link
Owner

@titusfortner titusfortner commented Jun 18, 2024

User description

Warning: Manually update the changelogs before merging

This PR:

  • Updates Rust version for Selenium Manager release
  • Updates Pinned browser version to coincide with new CDP release
  • Adds support for new CDP version and removes old CDP version
  • Selenium Manager references the new Selenium Manager release
  • Updates Maven Dependencies
  • Adds new authors to authors file
  • Updates all versions for all bindings
  • Generates rough change logs for each bindings (please tidy them up before merging this)

PR Type

enhancement, dependencies, documentation


Description

  • Updated DevTools package, class names, and imports from v123 to v126 across multiple languages (Java, C#, Ruby).
  • Updated browser versions for Firefox and Edge.
  • Updated Selenium Manager binaries to the latest release.
  • Updated Maven dependencies to the latest versions.
  • Added new authors to the authors file.
  • Updated changelog entries for version 4.22.0 across multiple languages (Java, C#, Ruby, Python, JavaScript).
  • Updated build configurations to support DevTools version 126.
  • Updated package versions to 4.22.0 across multiple languages (Java, C#, Ruby, Python, JavaScript).

Changes walkthrough 📝

Relevant files
Enhancement
30 files
v126Target.java
Update DevTools Target to version 126                                       

java/src/org/openqa/selenium/devtools/v126/v126Target.java

  • Updated package name from v123 to v126
  • Updated class name from v123Target to v126Target
  • Updated imports from v123 to v126
  • +12/-12 
    v126Network.java
    Update DevTools Network to version 126                                     

    java/src/org/openqa/selenium/devtools/v126/v126Network.java

  • Updated package name from v123 to v126
  • Updated class name from v123Network to v126Network
  • Updated imports from v123 to v126
  • +10/-10 
    v126Events.java
    Update DevTools Events to version 126                                       

    java/src/org/openqa/selenium/devtools/v126/v126Events.java

  • Updated package name from v123 to v126
  • Updated class name from v123Events to v126Events
  • Updated imports from v123 to v126
  • +9/-9     
    v126Domains.java
    Update DevTools Domains to version 126                                     

    java/src/org/openqa/selenium/devtools/v126/v126Domains.java

  • Updated package name from v123 to v126
  • Updated class name from v123Domains to v126Domains
  • Updated imports from v123 to v126
  • +13/-13 
    v126Javascript.java
    Update DevTools Javascript to version 126                               

    java/src/org/openqa/selenium/devtools/v126/v126Javascript.java

  • Updated package name from v123 to v126
  • Updated class name from v123Javascript to v126Javascript
  • Updated imports from v123 to v126
  • +7/-7     
    v126Log.java
    Update DevTools Log to version 126                                             

    java/src/org/openqa/selenium/devtools/v126/v126Log.java

  • Updated package name from v123 to v126
  • Updated class name from v123Log to v126Log
  • Updated imports from v123 to v126
  • +5/-5     
    v126CdpInfo.java
    Update DevTools CDP Info to version 126                                   

    java/src/org/openqa/selenium/devtools/v126/v126CdpInfo.java

  • Updated package name from v123 to v126
  • Updated class name from v123CdpInfo to v126CdpInfo
  • Updated constructor to use v126Domains
  • +4/-4     
    V126Domains.cs
    Update .NET DevTools Domains to version 126                           

    dotnet/src/webdriver/DevTools/v126/V126Domains.cs

  • Updated namespace from V123 to V126
  • Updated class name from V123Domains to V126Domains
  • Updated DevTools version to 126
  • +11/-11 
    V126Network.cs
    Update .NET DevTools Network to version 126                           

    dotnet/src/webdriver/DevTools/v126/V126Network.cs

  • Updated namespace from V123 to V126
  • Updated class name from V123Network to V126Network
  • Updated imports from V123 to V126
  • +12/-12 
    V126JavaScript.cs
    Update .NET DevTools JavaScript to version 126                     

    dotnet/src/webdriver/DevTools/v126/V126JavaScript.cs

  • Updated namespace from V123 to V126
  • Updated class name from V123JavaScript to V126JavaScript
  • Updated imports from V123 to V126
  • +8/-8     
    V126Target.cs
    Update .NET DevTools Target to version 126                             

    dotnet/src/webdriver/DevTools/v126/V126Target.cs

  • Updated namespace from V123 to V126
  • Updated class name from V123Target to V126Target
  • Updated imports from V123 to V126
  • +7/-7     
    V126Log.cs
    Update .NET DevTools Log to version 126                                   

    dotnet/src/webdriver/DevTools/v126/V126Log.cs

  • Updated namespace from V123 to V126
  • Updated class name from V123Log to V126Log
  • Updated imports from V123 to V126
  • +7/-7     
    DevToolsDomains.cs
    Add support for DevTools version 126 in .NET                         

    dotnet/src/webdriver/DevTools/DevToolsDomains.cs

    • Updated supported DevTools versions to include v126
    +1/-1     
    StableChannelChromeDriver.cs
    Update default ChromeDriver version to 126                             

    dotnet/test/common/CustomDriverConfigs/StableChannelChromeDriver.cs

    • Updated default browser version to 126
    +1/-1     
    version.rb
    Update Ruby DevTools version to 0.126.0                                   

    rb/lib/selenium/devtools/version.rb

    • Updated DevTools version to 0.126.0
    +1/-1     
    version.rb
    Update Ruby WebDriver version to 4.22.0                                   

    rb/lib/selenium/webdriver/version.rb

    • Updated WebDriver version to 4.22.0
    +1/-1     
    selenium-dotnet-version.bzl
    Update .NET Selenium version and supported DevTools versions

    dotnet/selenium-dotnet-version.bzl

  • Updated Selenium version to 4.22.0
  • Updated supported DevTools versions to include v126
  • +2/-2     
    __init__.py
    Update Python WebDriver version to 4.22.0                               

    py/selenium/webdriver/init.py

    • Updated WebDriver version to 4.22.0
    +1/-1     
    setup.py
    Update Python package version to 4.22.0                                   

    py/setup.py

    • Updated package version to 4.22.0
    +1/-1     
    versions.bzl
    Add support for DevTools version 126 in Java                         

    java/src/org/openqa/selenium/devtools/versions.bzl

    • Updated supported DevTools versions to include v126
    +1/-1     
    __init__.py
    Update Python Selenium version to 4.22.0                                 

    py/selenium/init.py

    • Updated Selenium version to 4.22.0
    +1/-1     
    version.bzl
    Update Java Selenium version to 4.22.0                                     

    java/version.bzl

    • Updated Selenium version to 4.22.0
    +1/-1     
    js_protocol.pdl
    Add protocol definitions for DevTools version 126               

    common/devtools/chromium/v126/js_protocol.pdl

    • Added new protocol definitions for version 126
    +1807/-1
    BUILD.bazel
    Add build rules for DevTools version 126                                 

    common/devtools/chromium/v126/BUILD.bazel

    • Added build rules for DevTools version 126
    +38/-1   
    WebDriver.csproj
    Update .NET DevTools generation command for version 126   

    dotnet/src/webdriver/WebDriver.csproj

    • Updated DevTools generation command to include v126
    +1/-1     
    Rakefile
    Update Rakefile release targets for version 126                   

    Rakefile

    • Updated release targets to include v126
    +1/-1     
    BUILD.bazel
    Update JavaScript build configuration for version 4.22.0 

    javascript/node/selenium-webdriver/BUILD.bazel

  • Updated version to 4.22.0
  • Updated supported browser versions to include v126
  • +2/-2     
    BUILD.bazel
    Update Python build configuration for version 4.22.0         

    py/BUILD.bazel

  • Updated version to 4.22.0
  • Updated supported browser versions to include v126
  • +2/-2     
    BUILD.bazel
    Update Java DevTools build configuration for version 126 

    java/src/org/openqa/selenium/devtools/v126/BUILD.bazel

    • Updated CDP version to v126
    +1/-1     
    BUILD.bazel
    Add support for DevTools version 126 in Ruby                         

    rb/lib/selenium/devtools/BUILD.bazel

    • Updated supported CDP versions to include v126
    +1/-1     
    Tests
    8 files
    DevToolsTargetTest.cs
    Update DevTools Target Test to version 126                             

    dotnet/test/common/DevTools/DevToolsTargetTest.cs

  • Updated CurrentCdpVersion to V126
  • Updated DevTools version to 126
  • +3/-3     
    DevToolsConsoleTest.cs
    Update DevTools Console Test to version 126                           

    dotnet/test/common/DevTools/DevToolsConsoleTest.cs

  • Updated CurrentCdpVersion to V126
  • Updated DevTools version to 126
  • +2/-2     
    DevToolsNetworkTest.cs
    Update DevTools Network Test to version 126                           

    dotnet/test/common/DevTools/DevToolsNetworkTest.cs

  • Updated CurrentCdpVersion to V126
  • Updated DevTools version to 126
  • +2/-2     
    DevToolsPerformanceTest.cs
    Update DevTools Performance Test to version 126                   

    dotnet/test/common/DevTools/DevToolsPerformanceTest.cs

  • Updated CurrentCdpVersion to V126
  • Updated DevTools version to 126
  • +2/-2     
    DevToolsProfilerTest.cs
    Update DevTools Profiler Test to version 126                         

    dotnet/test/common/DevTools/DevToolsProfilerTest.cs

  • Updated CurrentCdpVersion to V126
  • Updated DevTools version to 126
  • +2/-2     
    DevToolsSecurityTest.cs
    Update DevTools Security Test to version 126                         

    dotnet/test/common/DevTools/DevToolsSecurityTest.cs

  • Updated CurrentCdpVersion to V126
  • Updated DevTools version to 126
  • +2/-2     
    DevToolsTabsTest.cs
    Update DevTools Tabs Test to version 126                                 

    dotnet/test/common/DevTools/DevToolsTabsTest.cs

  • Updated CurrentCdpVersion to V126
  • Updated DevTools version to 126
  • +2/-2     
    DevToolsLogTest.cs
    Update DevTools Log Test to version 126                                   

    dotnet/test/common/DevTools/DevToolsLogTest.cs

  • Updated CurrentCdpVersion to V126
  • Updated DevTools version to 126
  • +1/-1     
    Dependencies
    5 files
    repositories.bzl
    Update browser versions for Firefox and Edge                         

    common/repositories.bzl

  • Updated Firefox beta version to 128.0b4
  • Updated Edge version to 126.0.2592.61
  • +9/-9     
    selenium_manager.bzl
    Update Selenium Manager binaries                                                 

    common/selenium_manager.bzl

    • Updated Selenium Manager binaries to new release
    +6/-6     
    MODULE.bazel
    Update Maven dependencies                                                               

    MODULE.bazel

    • Updated Maven dependencies to latest versions
    +25/-25 
    package-lock.json
    Update package-lock.json for version 4.22.0                           

    package-lock.json

    • Updated package version to 4.22.0
    +1/-1     
    package.json
    Update package.json for version 4.22.0                                     

    javascript/node/selenium-webdriver/package.json

    • Updated package version to 4.22.0
    +1/-1     
    Documentation
    7 files
    conf.py
    Update Python documentation version to 4.22.0                       

    py/docs/source/conf.py

    • Updated documentation version to 4.22.0
    +1/-1     
    AUTHORS
    Update authors file                                                                           

    AUTHORS

    • Added new authors to the authors file
    +5/-0     
    CHANGES
    Update Ruby changelog for version 4.22.0                                 

    rb/CHANGES

    • Added changelog entries for version 4.22.0
    +35/-0   
    CHANGES.md
    Update JavaScript changelog for version 4.22.0                     

    javascript/node/selenium-webdriver/CHANGES.md

    • Added changelog entries for version 4.22.0
    +17/-0   
    CHANGELOG
    Update Java changelog for version 4.22.0                                 

    java/CHANGELOG

    • Added changelog entries for version 4.22.0
    +16/-0   
    CHANGELOG
    Update .NET changelog for version 4.22.0                                 

    dotnet/CHANGELOG

    • Added changelog entries for version 4.22.0
    +16/-0   
    CHANGES
    Update Python changelog for version 4.22.0                             

    py/CHANGES

    • Added changelog entries for version 4.22.0
    +11/-0   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @titusfortner titusfortner marked this pull request as ready for review June 18, 2024 15:21
    @titusfortner titusfortner merged commit 9fe2397 into temp_trunk Jun 18, 2024
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 5
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review Version Consistency:
    Ensure that all version updates across different files and modules are consistent and correctly reference the new version 4.22.0.
    Dependency Updates:
    Review the updated dependencies for potential issues or conflicts, especially major version changes.
    Code Refactoring:
    The changes in the devtools directory, particularly the introduction of new classes and methods, should be thoroughly tested to ensure they meet the functional requirements.
    Security Concerns:
    With the introduction of new network-related updates and changes in handling exceptions and user inputs, ensure there are no new security vulnerabilities introduced.

    Copy link

    Failed to generate code suggestions for PR

    @titusfortner titusfortner deleted the release-preparation-4.22.0 branch June 18, 2024 15:57
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants