This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: replace libp2p peer ids with validator ids #319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freyskeyd
reviewed
Oct 6, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
- Coverage 61.07% 60.56% -0.51%
==========================================
Files 237 235 -2
Lines 13248 12934 -314
==========================================
- Hits 8091 7834 -257
+ Misses 5157 5100 -57
☔ View full report in Codecov by Sentry. |
gruberb
commented
Oct 11, 2023
dvdplm
reviewed
Oct 12, 2023
Freyskeyd
suggested changes
Oct 12, 2023
hadjiszs
suggested changes
Oct 12, 2023
dvdplm
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
hadjiszs
approved these changes
Oct 16, 2023
Freyskeyd
suggested changes
Oct 17, 2023
Freyskeyd
approved these changes
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing
PeerId
fromlibp2p
in the broadcast layer with our ownValidatorId
(which is a Ethereum public address -H160
as for now).Fixes TP-708
Additions and Changes
HashSet<ValidatorId>
, and supplies the list of validators through thegenesis.json
file during start.stable_sample
is set totrue
right awaycert_delivery
test is adjusted so each node hasvalidators
and avalidator_id
to start withBreaking changes
IMPORTANT: This removes the
--push-peer-list
command AND api endpoint.PR Checklist: