Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom_fileのtraitを変更 #31

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

comavius
Copy link
Member

関連Issue

概要

k8sのsubPathを使えば、同一のshared volume内にexec containerから可視なファイルと不可視なファイルの両方をおいておくことができる。

変更内容

  • FileEntity, FileLinkを削除
  • File::get_pathを削除
  • File::hardlinkを追加
  • FileFactory::get_hardlink_toを追加

補足

@comavius comavius self-assigned this Sep 27, 2024
@comavius comavius added the bug Something isn't working label Sep 27, 2024
@comavius comavius changed the title 🐛 use hardlink custom_fileのtraitを変更 Sep 27, 2024
@@ -6,18 +6,11 @@ use uuid::Uuid;
pub trait File: Sized + Drop {
type InitArgs;
fn new(path: PathBuf, args: Self::InitArgs) -> Result<Self>;
fn get_path(&self) -> PathBuf;
fn hard_link(&self, path: PathBuf) -> Result<Self>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set, create などの接頭辞が欲しい

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getにしたけどcreateのほうが良いかも

@comavius comavius requested a review from kenken714 September 27, 2024 04:09
Copy link
Collaborator

@kenken714 kenken714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comavius comavius merged commit 86fb83c into develop Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom_file/traitsを修正
2 participants