コメントのフォントサイズに下限を設定 fix #86 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
reviewed
Jun 30, 2021
|
:pro: |
|
最小な要素のindexを探す部分を切り分けてみました。 あと質問ですが、Vue の computed を使うタイミングとしては、Refのようなリアクティブな値から計算される値は基本的に computed でリアクティブにしたほうがいい、という理解であってますか？ |
|
リアクティブな値から算出される値に関しては、 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
スマホのような小さな画面でもコメントが読めるサイズになります
大きな画面では今までどおりのコメントの大きさです（ニコニコを真似した）
PR出してから気が付きましたが #85 を解決しかけているので、次は85のPRを書こうとおもっています。