Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging環境 #142

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Staging環境 #142

merged 6 commits into from
Jan 5, 2024

Conversation

H1rono
Copy link
Member

@H1rono H1rono commented Dec 21, 2023

No description provided.

@H1rono
Copy link
Member Author

H1rono commented Dec 21, 2023

  • デプロイ先のdocker-compose.yaml修正
  • GitHub Actionsのsecrets追加

@H1rono H1rono requested review from mehm8128 and ras0q December 21, 2023 14:03
Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UIの方と同様で、ここ直したら一旦入れてみちゃってよさそうです

.github/workflows/staging.yml Outdated Show resolved Hide resolved
Dockerfile Outdated
@@ -0,0 +1,17 @@
FROM --platform=$BUILDPLATFORM node:16.13.0-alpine as build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なんかめっちゃ古いの使ってるからついでにnodeのバージョン上げてもらえると助かります
.node-versionとこの行変えて、一応動作確認すればよさそうかな多分
バージョンはtraPortfolio-UIと同じのでよさそう
めんどくさかったら今回はやらなくてもいいです

@mehm8128
Copy link
Contributor

デプロイ先のdocker-compose.yaml修正
GitHub Actionsのsecrets追加

があんまり分かってないのですが、
「デプロイ先」ってサーバーのことですか?
「GitHub Actionsのsecrets追加」ってどのsecretのことですか?

@H1rono
Copy link
Member Author

H1rono commented Dec 21, 2023

「デプロイ先」ってサーバーのことですか?

はい、m011

「GitHub Actionsのsecrets追加」ってどのsecretのことですか?

key: ${{ secrets.STAGING_SSH_KEY }}
known_hosts: ${{ secrets.STAGING_KNOWN_HOSTS }}
- name: Deploy
run: ssh -t ${{ secrets.STAGING_DEPLOY_USER }}@${{ secrets.STAGING_DEPLOY_HOST }} "sudo sh /srv/portfolio/deploy.sh portfolio-dashboard"

ここに入ってるsecrets.***をGitHub Actionsの設定で追加する必要があります、具体的な値はtraPortfolioバックエンド参考に
H1ronoは権限の関係で見えないです

@mehm8128
Copy link
Contributor

なるほどです
そこらへんのsecretsはorganization secretsとして全リポジトリ共通で使えるように設定されてそうなので、なんもしなくて大丈夫そうです(バックエンドの方も特にリポジトリ単位では追加してなさそうです)

Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:kansya_kansya:

@H1rono
Copy link
Member Author

H1rono commented Jan 5, 2024

マージ可

@H1rono H1rono merged commit d99f7f4 into main Jan 5, 2024
5 checks passed
@H1rono H1rono deleted the staging branch January 5, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants