Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete: deprecated field prPermitted #419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Pugma
Copy link
Collaborator

@Pugma Pugma commented Jan 17, 2025

User description

UI リポジトリ同様、 API スキーマの変更に追従した


PR Type

Enhancement


Description

  • prPermitted フィールドを削除し、API スキーマ変更に対応

  • フォームの初期値設定を更新


Changes walkthrough 📝

Relevant files
Enhancement
UserAccountNew.vue
`prPermitted` フィールドの削除と初期値更新                                                         

src/pages/UserAccountNew.vue

  • prPermitted フィールドを削除
  • フォームの初期値設定を調整
+1/-2     

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Logic Issue

Ensure that the removal of the prPermitted field does not affect any dependent logic or functionality elsewhere in the application.

const formValues = reactive<AddAccountRequest>({
  type:
    serviceArray
      .filter(s => !registeredServices.value.includes(s.type))
      .map(s => s.type)[0] ?? 0,
  displayName: '',
  url: ''
})

Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@Pugma Pugma requested a review from Kaki256 January 17, 2025 15:46
@Pugma Pugma enabled auto-merge January 19, 2025 06:00
@Pugma Pugma disabled auto-merge January 19, 2025 06:00
@Pugma Pugma enabled auto-merge January 19, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant