Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユーザーアカウントAPIのprPermittedに当たる要素を全て消した #739

Merged
merged 6 commits into from
Jan 12, 2025

Conversation

Tennessine699
Copy link
Contributor

resolves #678

"prPermitted"とdatabaseのaccount.checkを消しました

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.95%. Comparing base (9276fbb) to head (acf37d2).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/infrastructure/migration/v3.go 25.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   71.06%   70.95%   -0.12%     
==========================================
  Files          42       43       +1     
  Lines        4576     4572       -4     
==========================================
- Hits         3252     3244       -8     
- Misses       1168     1170       +2     
- Partials      156      158       +2     
Flag Coverage Δ
integration 70.95% <52.63%> (-0.12%) ⬇️
unit 70.95% <52.63%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1rono H1rono requested review from ras0q and H1rono December 14, 2024 13:30
Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

差分だけ見ました
消し忘れてたらコンパイルエラー出るはずなので良さそうです
コメントのとこだけ命名直したらマージしちゃってください

internal/infrastructure/migration/v3.go Outdated Show resolved Hide resolved
Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、DBスキーマドキュメントの更新してなさそう
Readme見てそれだけやってほしいです

@Tennessine699 Tennessine699 requested a review from ras0q January 12, 2025 12:33
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@H1rono H1rono merged commit bd9c327 into main Jan 12, 2025
12 of 13 checks passed
@H1rono H1rono deleted the delete/account_pr-permitted branch January 12, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

アカウントの広報公開設定を消す
3 participants