Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlueskyをAccountTypeに追加 #745

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Tennessine699
Copy link
Contributor

resolves #738

Blueskyのプロフィールリンクの正規表現が見つからなかったのでいろいろ試してこれに落ち着きました
多分大丈夫だと思います

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.72%. Comparing base (9276fbb) to head (6e3f87e).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/domain/user.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   71.06%   70.72%   -0.34%     
==========================================
  Files          42       43       +1     
  Lines        4576     4578       +2     
==========================================
- Hits         3252     3238      -14     
- Misses       1168     1186      +18     
+ Partials      156      154       -2     
Flag Coverage Δ
integration 70.72% <83.33%> (-0.34%) ⬇️
unit 70.72% <83.33%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +144 to +146
"https://bsky.app/profile/bluesky.bsky.social",
"https://bsky.app/profile/tpf.bsky.social",
"https://bsky.app/profile/portfolio.trap.jp",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*.example.comを使うのが無難そうではある

Comment on lines -407 to +408
httpError(t, "Bad Request: validate error: type: must be no greater than 11."),
httpError(t, fmt.Sprintf("Bad Request: validate error: type: must be no greater than %d.", domain.AccountLimit-1)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ハードコードしてたのか

Comment on lines -407 to +408
httpError(t, "Bad Request: validate error: type: must be no greater than 11."),
httpError(t, fmt.Sprintf("Bad Request: validate error: type: must be no greater than %d.", domain.AccountLimit-1)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ハードコードしてたのか

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bluesky
2 participants