-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlueskyをAccountTypeに追加 #745
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 71.06% 70.72% -0.34%
==========================================
Files 42 43 +1
Lines 4576 4578 +2
==========================================
- Hits 3252 3238 -14
- Misses 1168 1186 +18
+ Partials 156 154 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
"https://bsky.app/profile/bluesky.bsky.social", | ||
"https://bsky.app/profile/tpf.bsky.social", | ||
"https://bsky.app/profile/portfolio.trap.jp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*.example.comを使うのが無難そうではある
httpError(t, "Bad Request: validate error: type: must be no greater than 11."), | ||
httpError(t, fmt.Sprintf("Bad Request: validate error: type: must be no greater than %d.", domain.AccountLimit-1)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ハードコードしてたのか
httpError(t, "Bad Request: validate error: type: must be no greater than 11."), | ||
httpError(t, fmt.Sprintf("Bad Request: validate error: type: must be no greater than %d.", domain.AccountLimit-1)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ハードコードしてたのか
resolves #738
Blueskyのプロフィールリンクの正規表現が見つからなかったのでいろいろ試してこれに落ち着きました
多分大丈夫だと思います