Allow for using CompleteOptionsToggle as more choices #202
Conversation
|
This pull request has been linked to 1 task:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -45,7 +45,7 @@ exports[`CompleteOptionsToggles matches snapshot 1`] = ` | |||
| disabled="" | |||
| /><span class="switch switch-background" | |||
| ><span class="switch switch-button"></span></span | |||
| >Essential purposes</label | |||
| >Essential</label | |||
There was a problem hiding this comment.
@csmccarthy not sure why this and yarn files updated
There was a problem hiding this comment.
i think we just forgot to run the snapshot update when going through the message changes. a diff here is nothing to worry about bc these strings will never be shown to the end user since purpose messages will always be defined
There was a problem hiding this comment.
lgtm aside from the type issues! as an aside i would love to not have to update airgap.js-types for things like this... we should probably transfer the ui to use the newer bundledData design and then have airgap implement a dumb passthrough for any data attributes prefixed with ui
Related Issues
by specifying
data-more-choices="CompleteOptionsToggle"on the airgap script tag, you can change the view state clicked when clickingmore choicesScreen.Recording.2024-12-11.at.8.24.45.PM.mov
@transcend-io/wario once we feel good about the name of the script tag parameter i can update airgap.js-types