Aerospike #2
Open
Aerospike #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an implementation of Aerospike StatefulSet found here: * https://github.com/aerospike/aerospike-kubernetes
ghost
requested review from
… can set more parameters. Now using selector we can use multiple admin built disks that is nearer to a production usage of aerospike
arochaf
reviewed
Oct 26, 2017
| proto-fd-max 15000 | ||
| } | ||
| logging { | ||
| file /var/log/aerospike/aerospike.log { |
There was a problem hiding this comment.
In principle with Kubernetes we don't need to log to files anymore. I think it should be enough to log to the console.
… service needs to be headless so aersopike cluster nodes can find each others by name
…use of internal balancers to expose nodes when cluster is a collection of separate installtions (helm requirements alias)
jeff-knurek
pushed a commit
that referenced
this pull request
Feb 6, 2018
* Create SQL Server 2017 Linux HELM Chart * Fixed spaces for ci/circleci * Fixed spaces for ci/circleci #2 * Fixed spaces for ci/circleci #3 * Added secret yaml to deployment for SA Password * Updated the chart to force user to specify EULA to Y for license terms * Updated README.md to reflect commandline option to accept EULA * Updated README.md and secret.yaml for sa_password generation * Fixed formatting error in NOTES.txt * Changed apiVersion in deployments.yaml to apps/v1beta2 * Allowed ability to override sapassword and change apiVersion in deployment.yaml * ci/circleci fixes * Updated release version, README.md, and hard-coded ports * Added port name, configured probes, moved to stable * Updated README.md
jeff-knurek
pushed a commit
that referenced
this pull request
Feb 7, 2019
* # This is a combination of 2 commits. # This is the 1st commit message: Initial commit Signed-off-by: Max Williams <[email protected]> # This is the commit message #2: updating sources * Commit Sign-off Signed-off-by: Miguel Angel Mingorance Fernandez <[email protected]> * Updating README table Signed-off-by: Miguel Angel Mingorance Fernandez <[email protected]>
cmoroianu1
pushed a commit
that referenced
this pull request
Jul 26, 2019
* [stable/grafana] Allow secrets for sidecar (helm#13492) Updated the sidecar image to version 0.0.18 This allows also using secrets for volume mounts This way the dashboard and datasource import can be extended to those datatypes Signed-off-by: Sergej Herbert <[email protected]> * [stable/grafana] Allow secret - review (helm#13492) - keep the appVersion the same - bump minor version - add missing apostrophe Signed-off-by: Sergej Herbert <[email protected]> * [stable/grafana] Allow secret - review #2 (helm#13492) - enable sidecar resource secrets and configmaps by default - update readme to indicate secret preference for datasources Signed-off-by: Sergej Herbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.