Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: possible optimization when removing zeros #11671

Closed
jhux2 opened this issue Mar 13, 2023 · 3 comments
Closed

Tpetra: possible optimization when removing zeros #11671

jhux2 opened this issue Mar 13, 2023 · 3 comments
Assignees
@jhux2
Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. pkg: Tpetra type: enhancement Issue is an enhancement, not a bug

Comments

@jhux2
Copy link
Member

jhux2 commented Mar 13, 2023

Enhancement

This is a potential follow-up to #11604. In removeCrsMatrixZeros there should be a check whether any zeros were actually removed. If not, then the function can just return early.
@jhux2 jhux2 added type: enhancement Issue is an enhancement, not a bug pkg: Tpetra labels Mar 13, 2023
@jhux2 jhux2 self-assigned this Mar 13, 2023
@brian-kelley brian-kelley mentioned this issue Mar 23, 2023
Merged
@github-actions GitHub Actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Mar 13, 2024
@jhux2 jhux2 added DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. and removed MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. labels Mar 13, 2024
@brian-kelley
Copy link
Contributor

@jhux2 I think #11715 took care of this, can it be closed?

@jhux2
Copy link
Member Author

jhux2 commented Apr 24, 2024

@brian-kelley Yep, thanks!

@jhux2 jhux2 closed this as completed Apr 24, 2024
@jhux2 jhux2 added this to Tpetra Aug 12, 2024
@jhux2 jhux2 moved this to Done in Tpetra Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhux2 jhux2

Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. pkg: Tpetra type: enhancement Issue is an enhancement, not a bug
Projects
Tpetra
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brian-kelley @jhux2