Tpetra: early exit from CRS remove zeros

[brian-kelley]

@trilinos/tpetra

Motivation

In Tpetra::removeCrsMatrixZeros, skip the fill-complete if there were no zeros to remove in the local matrices of all ranks (it cannot be skipped on only some ranks, because expertStaticFillComplete might do collectives, so all ranks must participate).

Related Issues

• Closes Tpetra: possible optimization when removing zeros #11671
• Blocks
• Is blocked by
• Follows
• Precedes
• Related to
• Part of
• Composed of

Stakeholder Feedback

Testing

Tested in Tpetra: CrsMatrix_UnitTests4

[jhux2]

Lgtm. Thanks, @brian-kelley!

[trilinos-autotester]

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

[trilinos-autotester]

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

• Build Num: 2008
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

• Build Num: 539
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

• Build Num: 534
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_clang-11.0.1

• Build Num: 534
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_python3

• Build Num: 1780
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

• Build Num: 1536
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_intel-2021.3

• Build Num: 174
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Using Repos:

Repo: TRILINOS (brian-kelley/Trilinos)

• Branch: Fix11671
• SHA: 1276282
• Mode: TEST_REPO

Pull Request Author: brian-kelley

[trilinos-autotester]

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

• Build Num: 2008
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

• Build Num: 539
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

• Build Num: 534
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_clang-11.0.1

• Build Num: 534
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_python3

• Build Num: 1780
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

• Build Num: 1536
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

Build Information

Test Name: Trilinos_PR_intel-2021.3

• Build Num: 174
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	type: enhancement;pkg: Tpetra;impacting: performance
PULLREQUESTNUM	11715
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	Fix11671
TRILINOS_SOURCE_REPO	https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA	1276282
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	30840e7

CDash Test Results for PR# 11715.

[trilinos-autotester]

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jhux2 ]!

[trilinos-autotester]

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...