Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect use of function only in later netCDF versions #12876

Closed
wants to merge 1 commit into from

Conversation

gsjaardema
Copy link
Contributor

The nc_def_var_fill function only exists in netCDF-4.6: or in earlier versions with NC_HAS_HDF5 defined.

@trilinos/seacas

Motivation

Stakeholder Feedback

Testing

The `nc_def_var_fill` function only exists in netCDF-4.6: or in earlier versions with `NC_HAS_HDF5` defined.
@gsjaardema gsjaardema added pkg: seacas AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed PA: Data Services Issues that fall under the Trilinos Data Services Product Area client: Albany Issue impacting the Albany project labels Apr 1, 2024
@gsjaardema gsjaardema requested a review from ikalash April 1, 2024 21:27
@gsjaardema gsjaardema self-assigned this Apr 1, 2024
@gsjaardema gsjaardema requested a review from a team as a code owner April 1, 2024 21:27
@github-actions github-actions bot added the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

You seem to have created a PR on master. This is not allowed behavior, so we've blocked your PR. Please switch your PR to target the develop branch and remove the AT: WIP label.

Copy link
Contributor

@ikalash ikalash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in the problematic build and have confirmed that the issue is fixed. Thanks!

@gsjaardema gsjaardema closed this Apr 1, 2024
@gsjaardema gsjaardema deleted the gsjaardema-patch-3 branch April 1, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) client: Albany Issue impacting the Albany project PA: Data Services Issues that fall under the Trilinos Data Services Product Area pkg: seacas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants