SEACAS: fix bad commits #12877

gsjaardema · 2024-04-01T21:44:35Z

@trilinos/seacas

Motivation

Remove uses of the lib::fmt include files in ioss header files that are installed and used by external clients. Since lib::fmt is used only as an embedded library in the Trilinos instantiation of SEACAS/IOSS, the installed include files cannot reference fmt files.

Also protect the use of the nc_def_var_fill function since it only appears in later versions of the netCDF library or in earlier versions that use the netcdf-4 (HDF5) capability.

Stakeholder Feedback

Testing

ikalash · 2024-04-01T22:22:47Z

I am still getting errors building Trilinos:

[ 81%] Building CXX object packages/seacas/libraries/ioss/src/main/CMakeFiles/io_info_lib.dir/volume.C.o
In file included from /home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/main/io_info.C:13:
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h: In instantiation of 'constexpr fmt::v9::detail::value<Context> fmt::v9::detail::make_value(T&&) [with Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; T = const Ioss::ZoneConnectivity&]':
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h:1795:29:   required from 'constexpr fmt::v9::detail::value<Context> fmt::v9::detail::make_arg(T&&) [with bool IS_PACKED = true; Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; fmt::v9::detail::type <anonymous> = fmt::v9::detail::type::custom_type; T = const Ioss::ZoneConnectivity&; typename std::enable_if<IS_PACKED, int>::type <anonymous> = 0]'
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h:1919:77:   required from 'constexpr fmt::v9::format_arg_store<Context, Args>::format_arg_store(T&& ...) [with T = {const Ioss::ZoneConnectivity&}; Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; Args = {Ioss::ZoneConnectivity}]'
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h:1936:31:   required from 'constexpr fmt::v9::format_arg_store<Context, fmt::v9::remove_cvref_t<Args>...> fmt::v9::make_format_args(Args&& ...) [with Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; Args = {const Ioss::ZoneConnectivity&}]'
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h:3314:44:   required from 'void fmt::v9::print(fmt::v9::format_string<T ...>, T&& ...) [with T = {const Ioss::ZoneConnectivity&}; fmt::v9::format_string<T ...> = fmt::v9::basic_format_string<char, const Ioss::ZoneConnectivity&>]'
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/main/io_info.C:311:33:   required from here
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h:1775:7: error: static assertion failed: Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt
 1775 |       formattable,
      |       ^~~~~~~~~~~
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h: In instantiation of 'constexpr fmt::v9::detail::value<Context> fmt::v9::detail::make_value(T&&) [with Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; T = const Ioss::BoundaryCondition&]':
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h:1795:29:   required from 'constexpr fmt::v9::detail::value<Context> fmt::v9::detail::make_arg(T&&) [with bool IS_PACKED = true; Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; fmt::v9::detail::type <anonymous> = fmt::v9::detail::type::custom_type; T = const Ioss::BoundaryCondition&; typename std::enable_if<IS_PACKED, int>::type <anonymous> = 0]'
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h:1919:77:   required from 'constexpr fmt::v9::format_arg_store<Context, Args>::format_arg_store(T&& ...) [with T = {const Ioss::BoundaryCondition&}; Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; Args = {Ioss::BoundaryCondition}]'
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h:1936:31:   required from 'constexpr fmt::v9::format_arg_store<Context, fmt::v9::remove_cvref_t<Args>...> fmt::v9::make_format_args(Args&& ...) [with Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; Args = {const Ioss::BoundaryCondition&}]'
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h:3314:44:   required from 'void fmt::v9::print(fmt::v9::format_string<T ...>, T&& ...) [with T = {const Ioss::BoundaryCondition&}; fmt::v9::format_string<T ...> = fmt::v9::basic_format_string<char, const Ioss::BoundaryCondition&>]'
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/main/io_info.C:329:32:   required from here
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos_GS/packages/seacas/libraries/ioss/src/private_copy_fmt/fmt/core.h:1775:7: error: static assertion failed: Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt
make[2]: *** [packages/seacas/libraries/ioss/src/main/CMakeFiles/io_info_lib.dir/io_info.C.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [packages/seacas/libraries/ioss/src/main/CMakeFiles/io_info_lib.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 81%] Linking CXX shared library libtpetra.so
[ 81%] Built target tpetra
make: *** [all] Error 2

This is with the gsjaardema:seacas-fix-bad-commits branch. Hopefully I used the right branch. Sorry that this is such a pain to fix...

gsjaardema · 2024-04-01T22:30:14Z

It looks like Ioss_ZoneConnectivity.h does need the fmt includes for building with Trilinos, but then they can't be present when being used external. I guess i need to check more closely how this changed on my latest PR instead of assuming I know what changed...

gsjaardema · 2024-04-01T22:40:43Z

@ikalash One more try... Sorry for the problems.

ikalash

It works now! Thank you for fixing!

trilinos-autotester · 2024-04-02T01:51:46Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

trilinos-autotester · 2024-04-02T01:51:48Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester · 2024-04-02T01:53:44Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 3896
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any&&!sandybridge
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 2395
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 2385
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 2384
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 3549
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 3387
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 2026
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_cuda-11.4.20-uvm

Build Num: 129
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Using Repos:

Repo: TRILINOS (gsjaardema/Trilinos)

Pull Request Author: gsjaardema

trilinos-autotester · 2024-04-02T02:34:48Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 3896
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any&&!sandybridge
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 2395
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 2385
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 2384
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 3549
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 3387
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 2026
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

Build Information

Test Name: Trilinos_PR_cuda-11.4.20-uvm

Build Num: 129
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM	12877
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA	`1fd7e97`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`6c485b0`

CDash Test Results for PR# 12877.

trilinos-autotester · 2024-04-02T02:35:07Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ikalash ]!

trilinos-autotester · 2024-04-02T02:35:14Z

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

trilinos-autotester · 2024-04-02T02:35:26Z

Merge on Pull Request# 12877: IS A SUCCESS - Pull Request successfully merged

gsjaardema added 2 commits April 1, 2024 15:39

EXODUS: Protect use of nc_def_var_fill function

db49703

IOSS: Remove use of fmt include in installed file

cd81cbf

gsjaardema added pkg: seacas AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed PA: Data Services Issues that fall under the Trilinos Data Services Product Area client: Albany Issue impacting the Albany project labels Apr 1, 2024

gsjaardema requested a review from ikalash April 1, 2024 21:44

gsjaardema self-assigned this Apr 1, 2024

gsjaardema requested a review from a team as a code owner April 1, 2024 21:44

IOSS: Try to fix problem with lib::fmt

1fd7e97

gsjaardema added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Apr 1, 2024

ikalash approved these changes Apr 2, 2024

View reviewed changes

trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Apr 2, 2024

trilinos-autotester merged commit 9d71c29 into trilinos:develop Apr 2, 2024
7 checks passed

trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Apr 2, 2024

gsjaardema deleted the seacas-fix-bad-commits branch April 2, 2024 13:26

SEACAS: fix bad commits #12877

SEACAS: fix bad commits #12877

Conversation

gsjaardema commented Apr 1, 2024

Motivation

Stakeholder Feedback

Testing

ikalash commented Apr 1, 2024

gsjaardema commented Apr 1, 2024

gsjaardema commented Apr 1, 2024

ikalash left a comment

Choose a reason for hiding this comment

trilinos-autotester commented Apr 2, 2024

trilinos-autotester commented Apr 2, 2024

trilinos-autotester commented Apr 2, 2024

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.20-uvm

Jenkins Parameters

Using Repos:

trilinos-autotester commented Apr 2, 2024

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.20-uvm

Jenkins Parameters

trilinos-autotester commented Apr 2, 2024

trilinos-autotester commented Apr 2, 2024

trilinos-autotester commented Apr 2, 2024