Build Updates for Ubuntu24.04 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 26649c2.
mc-nv
reviewed
Nov 1, 2024
tools/gen_ort_dockerfile.py
Outdated
| @@ -153,9 +154,11 @@ def dockerfile_for_linux(output_file): | |||
| && . /etc/os-release \\ | |||
| && echo "deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ $UBUNTU_CODENAME main" | tee /etc/apt/sources.list.d/kitware.list >/dev/null \\ | |||
| && apt-get update -q=2 \\ | |||
| && apt-get install -y --no-install-recommends cmake=3.27.7* cmake-data=3.27.7* \\ | |||
| && apt-get install -y --no-install-recommends cmake=3.28.* cmake-data=3.28.* \\ | |||
There was a problem hiding this comment.
Version 3.28 has a bug with CUDA Toolkit, it was fixed in latest versions.
https://gitlab.kitware.com/cmake/cmake/-/issues/25484
mc-nv
reviewed
Nov 4, 2024
mc-nv
approved these changes
Nov 4, 2024
mc-nv
added a commit
that referenced
this pull request
Nov 12, 2024
* Build Updates for Ubuntu24.04 (#282) * update cmake version * update versions for u24 * add compile_no_warning_as_error flag * remove libtbb copy * remove werror * add back libtbb * remove pip flag * add pip flag env var * Revert "add back libtbb" This reverts commit 26649c2. * include patch version in cmake install * Update python version * Restore installation of the missed package * Fix cudnn location --------- Co-authored-by: Anant Sharma <[email protected]>
mc-nv
added a commit
that referenced
this pull request
Nov 23, 2024
* Build Updates for Ubuntu24.04 (#282) * update cmake version * update versions for u24 * add compile_no_warning_as_error flag * remove libtbb copy * remove werror * add back libtbb * remove pip flag * add pip flag env var * Revert "add back libtbb" This reverts commit 26649c2. * include patch version in cmake install * Update python version * Restore installation of the missed package * Fix cudnn location --------- Co-authored-by: Anant Sharma <[email protected]>
mc-nv
added a commit
that referenced
this pull request
Nov 26, 2024
* Enable support for Ubuntu 24.04 (#283) * Build Updates for Ubuntu24.04 (#282) * update cmake version * update versions for u24 * add compile_no_warning_as_error flag * remove libtbb copy * remove werror * add back libtbb * remove pip flag * add pip flag env var * Revert "add back libtbb" This reverts commit 26649c2. * include patch version in cmake install * Update python version * Restore installation of the missed package * Fix cudnn location --------- Co-authored-by: Anant Sharma <[email protected]> * fix: Fix L0_onnx_execution_provider (#284) * Rollback to ORT 1.19.2 * Revert changes in ORT file * fix dockerfile * pre-commit fix --------- Co-authored-by: Misha Chornyi <[email protected]> --------- Co-authored-by: Anant Sharma <[email protected]> Co-authored-by: Yingge He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.