Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: RHEL8 EA2 Backends #7535

Closed
wants to merge 21 commits into from
Closed

build: RHEL8 EA2 Backends #7535

wants to merge 21 commits into from

Conversation

fpetrini15
Copy link
Contributor

@fpetrini15 fpetrini15 commented Aug 16, 2024

Goal: Support the PyTorch, TensorRT, and TensorFlow backends on RHEL8 systems. Importantly, these changes will disable optional PyTorch optional features such as TRITON_PYTORCH_ENABLE_TORCHTRT and TRITON_ENABLE_NVTX, which are not currently supported for the RHEL8 build.

PyTorch Backend: triton-inference-server/pytorch_backend#137
TensorRT Backend: triton-inference-server/tensorrt_backend#98
TensorFlow: triton-inference-server/tensorflow_backend#105
ORT Backend: triton-inference-server/onnxruntime_backend#266

@nv-kmcgill53
Copy link
Contributor

You need to fix your rebase to make sure the commit history is accurate. It's a bit of a pain you need to $git rebase -i <commit> and then drop the commits that are already in main. You should only keep the commits which are part of development. At the ends the commit history should only have the commits we have made on our dev branch and the total changes should be the same as what is listed in this PR.

If you are feeling uncertain about this, you can make a copy of your branch by just creating a new branch off the tip of this fpetrini-rhel branch (i.e. $git checkout -b copy-of-branch). Now you can try this out with the branch copy before you do it for real on this feature development branch. Let me know if you have any questions.

mc-nv
mc-nv previously approved these changes Aug 26, 2024
pvijayakrish and others added 21 commits August 26, 2024 10:52
More general capture of Linux Distros

tritonserver compiling except for --filesystem=gcs and --filesystem=s3

adding sbsa installation for dcgm

updating RUNPATH directory for tritonserver executable

cleanup

removed build_ubuntu and updated build.py
* Merge ORT RHEL changes Into Kyle's RHEL dev
More general capture of Linux Distros

tritonserver compiling except for --filesystem=gcs and --filesystem=s3

adding sbsa installation for dcgm

updating RUNPATH directory for tritonserver executable

cleanup

removed build_ubuntu and updated build.py
* Merge ORT RHEL changes Into Kyle's RHEL dev
Comment on lines +927 to +937
RUN yum install -y ca-certificates curl gnupg yum-utils \\
&& yum-config-manager --add-repo https://download.docker.com/linux/rhel/docker-ce.repo \\
&& yum install -y docker-ce docker-ce-cli containerd.io docker-buildx-plugin docker-compose-plugin
# && yum install -y docker.io docker-buildx-plugin

# libcurl4-openSSL-dev is needed for GCS
# python3-dev is needed by Torchvision
# python3-pip and libarchive-dev is needed by python backend
# libxml2-dev is needed for Azure Storage
# scons is needed for armnn_tflite backend build dep
RUN yum install -y \\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't yum update is required?
Also wondering why yum not dnf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mc-nv ignore these changes for now. There was an issue with the rebasing.

That said, you comments apply to our other RHEL PRs. In general, we can't do yum update because it will update the release version from 8.9 to 8.10, which would differ from the release version of the CUDA base container.

I have no preference for yum vs dnf.

# && . /etc/os-release \\
# && echo "deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ $UBUNTU_CODENAME main" | tee /etc/apt/sources.list.d/kitware.list >/dev/null \\
# && apt-get update -q=2 \\
# && apt-get install -y --no-install-recommends cmake=3.27.7* cmake-data=3.27.7*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comments needed?

@fpetrini15
Copy link
Contributor Author

Closing in favor of clean branch.

@fpetrini15 fpetrini15 closed this Aug 26, 2024
@fpetrini15 fpetrini15 deleted the fpetrini-rhel branch August 26, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants