Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Update to use custom vllm and TRT version at build and model generation respectively #7927

Merged
merged 20 commits into from
Jan 15, 2025
Merged

Build: Update to use custom vllm and TRT version at build and model generation respectively #7927

merged 20 commits into from
Jan 15, 2025
+72 −15

Conversation

pvijayakrish
Copy link
Contributor

What does the PR do?

Update to use custom vllm and TRT version at build and model generation respectively

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • [] test

@pvijayakrish pvijayakrish marked this pull request as draft January 10, 2025 19:00
mc-nv
mc-nv reviewed Jan 10, 2025
View reviewed changes
build.py Outdated Show resolved Hide resolved
mc-nv
mc-nv reviewed Jan 10, 2025
View reviewed changes
build.py Outdated Show resolved Hide resolved
mc-nv
mc-nv reviewed Jan 10, 2025
View reviewed changes
build.py Show resolved Hide resolved
@pvijayakrish pvijayakrish marked this pull request as ready for review January 13, 2025 18:55
@mc-nv mc-nv changed the base branch from main to r25.01 January 13, 2025 21:46
nv-kmcgill53
nv-kmcgill53 requested changes Jan 13, 2025
View reviewed changes
build.py Show resolved Hide resolved
qa/common/gen_qa_model_repository Show resolved Hide resolved
@nv-kmcgill53
Copy link
Contributor

Accidentally selected "Request Changes" when I did not suggest changes. These should be considered "Comments" instead

nv-kmcgill53
nv-kmcgill53 previously approved these changes Jan 13, 2025
View reviewed changes
mc-nv
mc-nv reviewed Jan 14, 2025
View reviewed changes
build.py Show resolved Hide resolved
mc-nv
mc-nv reviewed Jan 14, 2025
View reviewed changes
build.py Outdated Show resolved Hide resolved
mc-nv
mc-nv reviewed Jan 14, 2025
View reviewed changes
build.py Show resolved Hide resolved
mc-nv
mc-nv reviewed Jan 15, 2025
View reviewed changes
build.py Outdated Show resolved Hide resolved
mc-nv
mc-nv reviewed Jan 15, 2025
View reviewed changes
build.py Outdated Show resolved Hide resolved
@pvijayakrish pvijayakrish force-pushed the pvijayakrish-blackwell-devel branch from 351519b to c3f0534 Compare January 15, 2025 17:13
mc-nv
mc-nv requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@mc-nv mc-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many files for review

@mc-nv mc-nv force-pushed the pvijayakrish-blackwell-devel branch from 61404df to 27a5fb6 Compare January 15, 2025 19:32
mc-nv
mc-nv previously approved these changes Jan 15, 2025
View reviewed changes
@pvijayakrish pvijayakrish merged commit 67f067b into r25.01 Jan 15, 2025
3 checks passed
@pvijayakrish pvijayakrish deleted the pvijayakrish-blackwell-devel branch January 15, 2025 23:44
@pvijayakrish pvijayakrish restored the pvijayakrish-blackwell-devel branch January 15, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mc-nv mc-nv mc-nv approved these changes

@nvda-mesharma nvda-mesharma Awaiting requested review from nvda-mesharma

@nv-kmcgill53 nv-kmcgill53 Awaiting requested review from nv-kmcgill53

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvijayakrish @nv-kmcgill53 @mc-nv