Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] Remove all layout conversion decomposition functions from the NVIDIA backend #5553

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

Jokeren
Copy link
Contributor

@Jokeren Jokeren commented Jan 8, 2025

No description provided.

@Jokeren
Copy link
Contributor Author

Jokeren commented Jan 8, 2025

@binarman Could you please try to remove decompositions from the AMD backend as well?

@Jokeren Jokeren marked this pull request as ready for review January 8, 2025 03:03
@Jokeren Jokeren requested a review from ptillet as a code owner January 8, 2025 03:03
@Jokeren Jokeren requested a review from pawelszczerbuk January 8, 2025 03:04
@binarman
Copy link
Contributor

binarman commented Jan 8, 2025

@Jokeren
hi!
I am currently on vacation and can not do this right away. If this can wait, I will do this when back. If this is needed ASAP, please talk to @antiagainst.

Note: AMD backend has two decompositions used to reduce LDS usage, I think we should leave them(maybe move both of them in pass):

@Jokeren
Copy link
Contributor Author

Jokeren commented Jan 8, 2025

@binarman No worries. Sorry I forgot about that.

@antiagainst It's not urgent but I think it might be better to (1) rename the decomposition functions as there's no "unsupported" conversion anymore, and (2) move the function into the AMD backend only since the NVIDIA backend doesn't use them anymore. WDYT?

@antiagainst
Copy link
Collaborator

SG! We'll follow up on cleaning up the corresponding AMD pass afterwards.

@Jokeren Jokeren merged commit 37c7fc4 into main Jan 10, 2025
7 checks passed
@Jokeren Jokeren deleted the keren/no-decompose branch January 10, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants