This repository has been archived by the owner on Mar 16, 2023. It is now read-only.
Fixed color code revering issues and allow it to run on python 3.8.x #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed(?) how smi style color code converted to ass style. Changed and test to run on python 3.8.x on linux_x86-64 and arm Also, changed to not add "kor" on the end of the file when there is no other language is depicted. Also, add to print what file is currently working on. Also, some setting update.
On the original code, the cover conversion from smi to ass was wrong. It add new function that converting RGB to BGR
trustin
reviewed
Jun 5, 2021
| @@ -2,3 +2,4 @@ | |||
| /build | |||
| /test_smis/*.ass | |||
| __pycache__ | |||
| .vscode | |||
There was a problem hiding this comment.
Yes, this is automatically added by my IDE setting.
| import html | ||
| elif major == 3 and minor < 7: | ||
| from html.parser import HTMLParser | ||
| else: | ||
| print ('version 3.x needed') | ||
|
|
||
| default_lang_code = 'kor' |
There was a problem hiding this comment.
Could you let me know why this had to be removed?
There was a problem hiding this comment.
I thought if the subtitle file only incused single language in the subtitle it is meaningless to add kor on the file name. Since already know what language is in the subtitle file.
| import html | ||
| elif major == 3 and minor < 7: | ||
| from html.parser import HTMLParser | ||
| else: | ||
| print ('version 3.x needed') | ||
|
|
||
| default_lang_code = 'kor' | ||
| default_font_name = 'sans-serif' | ||
| default_font_name = 'Malgun Gothic' |
There was a problem hiding this comment.
How about using fonts like "Noto Sans CJK KR" instead, given Malgun Gothic is not available in non-Windows?
There was a problem hiding this comment.
This is part of my mistake, while using and testing this program, I modified the ass to match with my subtitle settings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed(?) how smi style color code converted to ass style.
Changed and test to run on python 3.8.x on linux_x86-64 and arm Also, changed to not add "kor" on the end of the file when there is no other language is depicted.
Also, add to print what file is currently working on.
Also, some setting updates.