feat(ecmascript): implement array constructor builtins #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliassjogreen
changed the title
aapoalas
requested changes
May 14, 2024
There was a problem hiding this comment.
Awesome stuff, thank you for doing this! <3
There's unfortunately a string/integer PropertyKey thing here that we should resolve, caused by a bug in the engine. I left issue: comments in those places that should be changed before merging. Note: The comment "notation" comes from Conventional Comments.
Anyway, absolutely awesome stuff, thank you so much! <3
nova_vm/src/ecmascript/abstract_operations/operations_on_iterator_objects.rs
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_constructor.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_constructor.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_constructor.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_constructor.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_constructor.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_constructor.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_constructor.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_constructor.rs
Outdated
Show resolved
Hide resolved
aapoalas
reviewed
May 15, 2024
aapoalas
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the array constructor builtin functions according to spec.
Closes #143