Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test262): Implement the detachArrayBuffer test harness function #498

Merged
merged 5 commits into from
Jan 3, 2025
Merged

feat(test262): Implement the detachArrayBuffer test harness function #498

merged 5 commits into from
Jan 3, 2025

Conversation

eliassjogreen
Copy link
Member

@eliassjogreen eliassjogreen commented Jan 3, 2025 •
edited
Loading

No description provided.

@eliassjogreen eliassjogreen force-pushed the feat/test262-detach-array-buffer branch from dfa05b2 to 722696d Compare January 3, 2025 16:49
@eliassjogreen eliassjogreen force-pushed the feat/test262-detach-array-buffer branch from 722696d to 42918b4 Compare January 3, 2025 16:49
aapoalas
aapoalas approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

aapoalas
aapoalas requested changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, on second thought: Maybe rather make the detach a public method on the ArrayBuffer struct that just calls the AO. It's maybe a bit cleaner than publishing AOs.

@eliassjogreen eliassjogreen requested a review from aapoalas January 3, 2025 18:00
@aapoalas aapoalas merged commit 457b532 into trynova:main Jan 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliassjogreen @aapoalas