Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add needStopPreview param #227

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Add needStopPreview param #227

merged 1 commit into from
Dec 4, 2024

Conversation

XiaooSe
Copy link
Contributor

@XiaooSe XiaooSe commented Dec 4, 2024

Owner

  • Nickname(Tuya): 萧瑟
  • Intra-group review(组内审阅人员):萧瑟

Description

Add param: needStopPreview

Package

Please select the relevant package.

  • tuya-panel-animation-sdk
  • tuya-panel-api
  • tuya-panel-electrician-sdk
  • tuya-panel-ipc-sdk
  • tuya-panel-lamp-sdk
  • tuya-panel-lock-sdk
  • tuya-panel-robot-sdk
  • tuya-panel-outdoor-sdk

Type of change

Please select the relevant option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Self CheckList

Please check all options.

  • Intra-group review
  • ESLint lint
  • Example Run
  • Jest Run
  • No Grammer Error
  • No Spell Error
  • No Merge Conflict


if (showCutScreen) {
TYEvent.emit('hideScreenListen', {});
}

if (!enterBackDisConP2P) {
if (!needStopPreview) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里切换属性判断没有破坏性变更影响吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无影响,针对语音模式无使用地方,此处添加此逻辑 需要针对所有进入原生页面 进行停流,属于优化

@ShinyLeee ShinyLeee merged commit 12a8aba into tuya:main Dec 4, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants