kgo: fix accounting when topics/partitions are {,un}paused for PollRecords #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cords Topics or partitions that were paused (in `takeNBuffered` specifically, which is used by PollRecords) did not have proper accounting for stripped (removed) topics or partitions. PollFetches does not have this problem because the logic is different -- we build a big fetch, call our accounting logic, and then remove the stripped topics & partitions. Instead in takeNBuffered, we skip topics and partitions as we build a fetch and then once the fetch is built, do the accounting. The fix is to build a separate internal-only fetch of everything that was stripped and pass that to our accounting hooks. Fixes #865.
twmb
changed the title
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topics or partitions that were paused (in
takeNBufferedspecifically, which is used by PollRecords) did not have proper accounting for stripped (removed) topics or partitions. PollFetches does not have this problem because the logic is different -- we build a big fetch, call our accounting logic, and then remove the stripped topics & partitions. Instead in takeNBuffered, we skip topics and partitions as we build a fetch and then once the fetch is built, do the accounting.The fix is to build a separate internal-only fetch of everything that was stripped and pass that to our accounting hooks.
Fixes #865.