CI updates #169
Merged
CI updates #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masklinn
force-pushed
the
ci-extensions
branch
from
42c3a4e to
4c8967a
Compare
masklinn
force-pushed
the
ci-extensions
branch
2 times, most recently
from
32ec9b2 to
cd843f2
Compare
~~Apparently github's automerge is based on the job's properties not the branch protection rules.~~ From what I gather, seems to make the overall job succeed even if a specific run fails. This is exactly what we want. After checking again the selection was such a pain in the ass I got one of the status checks wrong in the ruleset, and selected one of the pypy-3.11 jobs as required. Even after `continue-on-error`-ing and the overall check now passing the branch still doesn't merge. `continue-on-error` seems like it's useful regardless, for better reporting, so leaving it.
masklinn
force-pushed
the
ci-extensions
branch
from
cd843f2 to
bf10103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164