-
Notifications
You must be signed in to change notification settings - Fork 296
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Go 1.22 is the minimum supported Go version right now. Bump the constraint in go.mod to reflect that, and also pick up the `for` loop semantic changes made in Go 1.22 [1]. [1]: https://go.dev/blog/loopvar-preview Without this, `go vet` fails on the latest Go with: ``` Error: app_test.go:441:6: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:451:26: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:466:7: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:473:7: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:479:6: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:546:7: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:559:8: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:574:6: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:597:22: loopclosure: loop variable tt captured by func literal (govet) Error: app_test.go:604:8: loopclosure: loop variable tt captured by func literal (govet) ```
- Loading branch information
Showing
6 changed files
with
10 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
module go.uber.org/fx/docs | ||
|
||
go 1.20 | ||
go 1.22 | ||
|
||
require ( | ||
github.com/stretchr/testify v1.8.1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
module go.uber.org/fx | ||
|
||
go 1.20 | ||
go 1.22 | ||
|
||
require ( | ||
github.com/stretchr/testify v1.8.1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
module go.uber.org/fx/internal/e2e | ||
|
||
go 1.20 | ||
go 1.22 | ||
|
||
require ( | ||
github.com/stretchr/testify v1.8.2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters