Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile with al2 changes #23

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Add Dockerfile with al2 changes #23

merged 2 commits into from
Dec 20, 2024

Conversation

nss10
Copy link
Contributor

@nss10 nss10 commented Dec 18, 2024

  • Change the base docker file to Amazlon Linux

tianj7
tianj7 previously approved these changes Dec 20, 2024
Copy link

@tianj7 tianj7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment about case matching otherwise lgtm.

Dockerfile Outdated
ARG AZLINUX_BASE_VERSION=feat_python-nginx

# ------ Base stage ------
FROM quay.io/cdis/python-nginx-al:${AZLINUX_BASE_VERSION} as builder
Copy link

@tianj7 tianj7 Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally update the case to improve readability here.

Copy link

@tianj7 tianj7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nss10 nss10 merged commit 615586a into master Dec 20, 2024
2 checks passed
@nss10 nss10 deleted the feat/al2 branch December 20, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants