Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Code Selection Button #421

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Added Code Selection Button #421

merged 2 commits into from
Jan 20, 2024

Conversation

lawtlee
Copy link
Contributor

@lawtlee lawtlee commented Jan 19, 2024

Summary

Closes #390

Added Code Selection component. It is still a little raw, need to have a handleClick function. Basically pass the useState function over to change the value and check it to see if its the right answer or not.

Screenshots

image

@lawtlee lawtlee requested a review from Dankco January 19, 2024 21:34
Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for parcel-pointers ready!

Name Link
🔨 Latest commit 33e5538
🔍 Latest deploy log https://app.netlify.com/sites/parcel-pointers/deploys/65aaeb24b6e3500008debf55
😎 Deploy Preview https://deploy-preview-421--parcel-pointers.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Dankco Dankco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. I think we did some state handling of the dropdowns in Excercise 1 differently-
https://github.com/uclaacm/parcel-pointers/blob/main/src/components/Dropdown.tsx
to help make this handle state correctly within the page. I really should have put this as a thing to reference on the ticket.
Good job though, this is good first step toward creating Excercise 2!

@Dankco Dankco merged commit 32fc1b9 into main Jan 20, 2024
6 checks passed
@Dankco Dankco deleted the 390_Select_Code branch January 20, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Create new Code Filling Component
2 participants