Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created exercise2 skeleton #427

Merged
merged 5 commits into from
Jan 23, 2024
Merged

created exercise2 skeleton #427

merged 5 commits into from
Jan 23, 2024

Conversation

lilyorlilypad
Copy link
Contributor

#389

Some issues with the Runcode component:
It doesn't display the placerholder "select"
It currently only accepts one answer as correct
There is no way display different messages for different incorrect choices.

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for parcel-pointers ready!

Name Link
🔨 Latest commit 9dc0899
🔍 Latest deploy log https://app.netlify.com/sites/parcel-pointers/deploys/65b036099e90d80008f921a4
😎 Deploy Preview https://deploy-preview-427--parcel-pointers.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lilyorlilypad lilyorlilypad requested a review from Dankco January 23, 2024 18:06
Copy link
Contributor

@Dankco Dankco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! There are some more issues that you pointed out and that I also noticed with the component, so I will ticket those up.

@Dankco Dankco merged commit 2c71846 into main Jan 23, 2024
6 checks passed
@Dankco Dankco deleted the 389-exercise2 branch January 23, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants