-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing a compiler warning in create_xgrid.c #992
Fixing a compiler warning in create_xgrid.c #992
Conversation
…function "insertIntersect" declared implicitly)
@BijuThomas-NOAA - On what machine(s) do you see the warning? Does the warning happen with the 'Release' or 'Debug' compiles? |
On WCOSS2, build type is Release
|
@BijuThomas-NOAA - I compiled 2323761 on Cactus in both 'Release' and 'Debug' mode. I did not see that warning. The only warnings I see concern libjpeg, which I don't know how to fix. |
The warning can be reproduced on Cactus in UFS_UTILS submodule (based on 6dee392 I think) in the HAFS production branch once the prototype is removed: /lfs/h2/emc/hur/noscrub/biju.thomas/save/hafs_prod.v2/sorc/utils_build.log
|
@BijuThomas-NOAA - I am going to close this. These warnings were already fixed. |
DESCRIPTION OF CHANGES:
During HAFS v2.0 operational implementation NCO asked the team to resolve all compiler warnings. The "insertIntersect" function in sorc/fre-nctools.fd/shared_lib/create_xgrid.c is declared implicitly and it raises the
compiler warning. In this pull request, the prototype of "insertIntersect" function is added in create_xgrid.c to fix the compiler warning.
TESTS CONDUCTED:
The proposed change was tested in the HAFS system. No other tests were conducted.
Need assistance to conduct the following tests.
Optional test.
Describe any additional tests performed.
DEPENDENCIES:
N/A
DOCUMENTATION:
If this PR is contributing new capabilities that need to be documented, please also include updates to the RST files in the docs/source directory as supporting material.
ISSUE:
If this PR is resolving or referencing one or more issues, in this repository or elsewhere, list them here. For example, "Fixes issue mentioned in #123" or "Related to bug in https://github.com/NOAA-EMC/other_repository/pull/63"