Using temp memory stream

uholeschak · Dec 20, 2024 · 61c137f · 61c137f
1 parent 67a7abb
commit 61c137f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/Tools/ApkUncompress2/AssemblyStore/AssemblyStoreExplorer.cs b/Tools/ApkUncompress2/AssemblyStore/AssemblyStoreExplorer.cs
@@ -167,8 +167,14 @@ public static (IList<AssemblyStoreExplorer>? explorers, string? errorMessage) Op
 
                 if (string.Compare(zipEntry.Name, path, StringComparison.OrdinalIgnoreCase) == 0)
                 {
-                    Stream zipStream = zf.GetInputStream(zipEntry);
-                    ret.Add(new AssemblyStoreExplorer(zipStream, $"{fi.FullName}!{path}"));
+                    MemoryStream memoryStream = new MemoryStream();
+                    byte[] buffer = new byte[4096]; // 4K is optimum
+                    using (Stream zipStream = zf.GetInputStream(zipEntry))
+                    {
+                        StreamUtils.Copy(zipStream, memoryStream, buffer);
+                    }
+
+                    ret.Add(new AssemblyStoreExplorer(memoryStream, $"{fi.FullName}!{path}"));
                     break;
                 }
             }

diff --git a/Tools/ApkUncompress2/Program.cs b/Tools/ApkUncompress2/Program.cs
@@ -73,7 +73,7 @@ static int Main(string[] args)
                             }
 
                             Directory.CreateDirectory(outDir);
-                            using (var fileStream = File.Create(outFile))
+                            using (FileStream fileStream = File.Create(outFile))
                             {
                                 stream.Seek(0, SeekOrigin.Begin);
                                 stream.CopyTo(fileStream);