feat(agent): support authenticated proxies when mitm is disabled

ulixee · Jan 20, 2025 · 9946794 · 9946794
1 parent 19de3ad
commit 9946794
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/agent/main/interfaces/IProxyConnectionOptions.ts b/agent/main/interfaces/IProxyConnectionOptions.ts
@@ -1,4 +1,5 @@
 export default interface IProxyConnectionOptions {
   address: string;
+  username?: string;
   password?: string;
 }
diff --git a/agent/main/lib/Agent.ts b/agent/main/lib/Agent.ts
@@ -54,10 +54,9 @@ export default class Agent extends TypedEventEmitter<{ close: void }> {
 
   private get proxyConnectionInfo(): IProxyConnectionOptions {
     if (!this.enableMitm) {
-      if (this.emulationProfile.upstreamProxyUrl) {
-        return { address: this.emulationProfile.upstreamProxyUrl };
-      }
-      return null;
+      if (!this.emulationProfile.upstreamProxyUrl) return null;
+      const url = new URL(this.emulationProfile.upstreamProxyUrl);
+      return { address: url.origin, username: url.username, password: url.password };
     }
     if (this.isolatedMitm) {
       // don't use password for an isolated mitm proxy