tests: testing ibc transactions on e2e tests #2284

gsk967 · 2023-10-16T10:23:47Z

Description

In this pull request we are upgraded hermes relayer to v1.6.0 and gaia to v13.0.0 , to make sure all our testing images up to date

We are using hermes image from docker hub

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

codecov · 2023-10-16T10:30:14Z

Codecov Report

Merging #2284 (c3f3c0d) into main (7f05ad4) will decrease coverage by 4.90%.
Report is 264 commits behind head on main.
The diff coverage is 83.12%.

❗ Current head c3f3c0d differs from pull request most recent head c09028f. Consider uploading reports for the commit c09028f to get more accurate results

@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
- Coverage   75.38%   70.49%   -4.90%     
==========================================
  Files         100      170      +70     
  Lines        8025    12882    +4857     
==========================================
+ Hits         6050     9081    +3031     
- Misses       1589     3198    +1609     
- Partials      386      603     +217

Files	Coverage Δ
ante/ante.go	`66.66% <100.00%> (+18.45%)`	⬆️
ante/fee.go	`80.00% <100.00%> (+1.64%)`	⬆️
ante/spam_prevention.go	`75.92% <ø> (ø)`
app/inflation/inflation.go	`100.00% <100.00%> (ø)`
util/coin/utoken.go	`100.00% <100.00%> (ø)`
x/incentive/client/tests/suite.go	`100.00% <100.00%> (ø)`
x/incentive/client/tests/tests.go	`100.00% <100.00%> (ø)`
x/incentive/codec.go	`47.82% <ø> (+9.89%)`	⬆️
x/incentive/genesis.go	`92.48% <100.00%> (+79.14%)`	⬆️
x/incentive/keeper/bond.go	`92.50% <ø> (ø)`
... and 44 more

... and 95 files with indirect coverage changes

gsk967 · 2023-10-17T13:09:16Z

Note: once it is merged , we need to changehermes relayer and gaia images and we need build new ones and push to ghcr and raise new PR with changing image names on tests
@robert-zaremba @toteki

…e_ibc

gsk967 · 2023-10-18T17:16:10Z

tests/e2e/e2e_ibc_test.go

@@ -64,31 +64,24 @@ func (s *E2ETest) checkOutflows(umeeAPIEndpoint, denom string, checkWithExcRate
 }

 func (s *E2ETest) checkSupply(endpoint, ibcDenom string, amount math.Int) {
-	attempt := 1


I am removing attempt from here bcause the relayer taking so much time making ibc txn submitting on both sides

gsk967 · 2023-10-18T17:17:07Z

tests/e2e/scripts/gaia_bootstrap.sh

@@ -10,5 +12,5 @@ gaiad collect-gentxs
 sed -i 's/127.0.0.1:26657/0.0.0.0:26657/g' /root/.gaia/config/config.toml
 sed -i -e 's/enable = false/enable = true/g' /root/.gaia/config/app.toml
 sed -i -e 's/pruning = "default"/pruning = "nothing"/g' /root/.gaia/config/app.toml
-sed -i 's/timeout_commit = "5s"/timeout_commit = "300ms"/g' /root/.gaia/config/config.toml


it is too fast 300ms , so relayer needs to catup the blocks height , so I making 1s

gsk967 · 2023-10-18T17:17:43Z

tests/e2e/scripts/hermes_bootstrap.sh

 port = 3001

 [[chains]]
 id = '$UMEE_E2E_UMEE_CHAIN_ID'
 rpc_addr = 'http://$UMEE_E2E_UMEE_VAL_HOST:26657'
 grpc_addr = 'http://$UMEE_E2E_UMEE_VAL_HOST:9090'
-websocket_addr = 'ws://$UMEE_E2E_UMEE_VAL_HOST:26657/websocket'
+event_source = { mode = 'push', url = 'ws://$UMEE_E2E_UMEE_VAL_HOST:26657/websocket', batch_delay = '500ms' }


batch_delay 500ms they are recommended with their tests

gsk967 · 2023-10-18T17:18:37Z

tests/e2e/setup/ibc.go

+		func() bool {
+			s.T().Log("We are waiting for channel creation...")
+			channels, err := s.QueryIBCChannels(s.UmeeREST())
+			if channels {


We need to wait for ibc channels creation before making the ibc txn

gsk967 · 2023-10-18T17:20:13Z

tests/e2e/setup/utils.go

-			}
-			return err == nil
-		}, 5*time.Second, 200*time.Millisecond, "require tx to be included in block")
+		// Note: we are cchecking only one side of ibc , we don't know whethever ibc transfer is succeed on one side


I am commenting this LOC, becuase we are checking only one side of ibc txn , we don't know whether ibc is succeed on other side of ibc

was this working before? Why it doesn't work now?

No, it is not working previously because they check only one side on ibc

Previously When I wrote this , there is no txn checking , we are just waiting around 12 seconds I think for every IBC Txn

tests/e2e/docker/gaia.Dockerfile

robert-zaremba · 2023-10-18T20:43:21Z

tests/e2e/e2e_ibc_test.go

 			return false
 		},
-		2*time.Minute,
+		10*time.Minute,


why do we increase it to 10min? that sounds too much...

We don't know ibc txn is succeed or not, we only know txn is succceed when that denom exists in supply query

10 minutes I know it is too much but that is the maximum time to check the ibc txn because sometimes hermes relayer taking too much time submit the ibc txn on both sides

for e2e tests, 10min is too much. Can we keep it to 2 or 3 min?

We don't know how much time taking to succeed ibc txn with this new hermes , so I keep maximum 10m , 2minutes or 3 minutes not enough at least it required 6minutes to check the supply (like ibc txn to succeed)

I will update this time in next PR (once cross checking done with go relayer and hermes )

tests/e2e/e2e_ibc_test.go

robert-zaremba · 2023-10-18T20:45:28Z

tests/e2e/e2e_ibc_test.go

 		// send $15 ATOM from umee to gaia
-		sendAtom := mulCoin(atomQuota, "0.15")
+		sendAtom := mulCoin(atomQuota, "0.05")


why do we change the amount here?

just making sure the total sending quota is always less than TotalQuota (120$)

robert-zaremba · 2023-10-18T20:50:45Z

tests/e2e/setup/utils.go

-			}
-			return err == nil
-		}, 5*time.Second, 200*time.Millisecond, "require tx to be included in block")
+		// Note: we are cchecking only one side of ibc , we don't know whethever ibc transfer is succeed on one side


was this working before? Why it doesn't work now?

robert-zaremba · 2023-10-18T20:51:04Z

tests/e2e/setup/ibc.go

+			}
+			return channels
+		},
+		10*time.Minute,


10min is a lot

* WIP: testing ibc txn on e2e tests * using testing docker images of gaia and hermes relayer * fixing the tests * fix the calculation on tests * fix++ * fix++ * fix++ * fix++ * adding default hermes relayer image * using ghcr gaia

gsk967 and others added 2 commits October 16, 2023 15:53

WIP: testing ibc txn on e2e tests

3851bd1

Merge branch 'main' into sai/fix_e2e_ibc

1853956

gsk967 and others added 8 commits October 17, 2023 13:57

using testing docker images of gaia and hermes relayer

e9ed607

Merge branch 'main' into sai/fix_e2e_ibc

561061d

fixing the tests

50c1627

fix the calculation on tests

e297422

fix++

5cc00b0

fix++

50eb415

fix++

ad427f3

fix++

dfc4692

gsk967 marked this pull request as ready for review October 17, 2023 13:08

gsk967 requested a review from a team as a code owner October 17, 2023 13:08

gsk967 enabled auto-merge October 17, 2023 13:09

gsk967 changed the title ~~tests(WIP): testing ibc transactions on e2e tests~~ tests: testing ibc transactions on e2e tests Oct 17, 2023

gsk967 and others added 4 commits October 18, 2023 16:56

Merge branch 'main' into sai/fix_e2e_ibc

40c6243

adding default hermes relayer image

552ebff

Merge remote-tracking branch 'origin/sai/fix_e2e_ibc' into sai/fix_e2…

d60e4a1

…e_ibc

using ghcr gaia

c3f3c0d

gsk967 requested review from toteki and robert-zaremba October 18, 2023 17:14

gsk967 commented Oct 18, 2023

View reviewed changes

tests/e2e/docker/gaia.Dockerfile Show resolved Hide resolved

robert-zaremba reviewed Oct 18, 2023

View reviewed changes

robert-zaremba approved these changes Oct 19, 2023

View reviewed changes

Merge branch 'main' into sai/fix_e2e_ibc

c09028f

gsk967 added this pull request to the merge queue Oct 19, 2023

Merged via the queue into main with commit 52bade8 Oct 19, 2023
20 of 21 checks passed

gsk967 deleted the sai/fix_e2e_ibc branch October 19, 2023 11:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: testing ibc transactions on e2e tests #2284

tests: testing ibc transactions on e2e tests #2284

gsk967 commented Oct 16, 2023 •

edited

Loading

codecov bot commented Oct 16, 2023 •

edited

Loading

gsk967 commented Oct 17, 2023 •

edited

Loading

gsk967 Oct 18, 2023

gsk967 Oct 18, 2023

gsk967 Oct 18, 2023

gsk967 Oct 18, 2023

gsk967 Oct 18, 2023

robert-zaremba Oct 18, 2023

gsk967 Oct 19, 2023

gsk967 Oct 19, 2023

robert-zaremba Oct 18, 2023

gsk967 Oct 19, 2023

gsk967 Oct 19, 2023

robert-zaremba Oct 19, 2023

gsk967 Oct 19, 2023

robert-zaremba Oct 18, 2023

gsk967 Oct 19, 2023

robert-zaremba Oct 18, 2023

robert-zaremba Oct 18, 2023

tests: testing ibc transactions on e2e tests #2284

tests: testing ibc transactions on e2e tests #2284

Conversation

gsk967 commented Oct 16, 2023 • edited Loading

Description

Author Checklist

Reviewers Checklist

codecov bot commented Oct 16, 2023 • edited Loading

Codecov Report

gsk967 commented Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gsk967 commented Oct 16, 2023 •

edited

Loading

codecov bot commented Oct 16, 2023 •

edited

Loading

gsk967 commented Oct 17, 2023 •

edited

Loading