Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2449] Revert changes that have been merged by mistake in CI… #1682

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[UNDERTOW-2449] Revert changes that have been merged by mistake in CI… #1682

merged 2 commits into from
Oct 16, 2024

Conversation

fl4via
Copy link
Member

@fl4via fl4via commented Oct 11, 2024

… when investigating PushResourceRSTTestCase

Jira: https://issues.redhat.com/browse/UNDERTOW-2449

@fl4via
[UNDERTOW-2449] Revert changes that have been merged by mistake in CI…
a1deb11 
… when investigating PushResourceRSTTestCase

Signed-off-by: Flavia Rainone <[email protected]>
@fl4via fl4via added enhancement Enhances existing behaviour or code waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review under verification Currently being verified (running tests, reviewing) before posting a review to contributor and removed waiting peer review PRs that edit core classes might require an extra review labels Oct 11, 2024
@fl4via fl4via marked this pull request as draft October 11, 2024 11:57
@fl4via
Copy link
Member Author

fl4via commented Oct 11, 2024

I'll investigate this later today. Unfortunately, the test is not passing on proxy scenarios. I'll see if I want to have the test merged with proxy tests disabled or not after I figure what exactly is happening

@fl4via fl4via removed the waiting CI check Ready to be merged but waiting for CI check label Oct 11, 2024
@fl4via fl4via added waiting CI check Ready to be merged but waiting for CI check and removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor labels Oct 15, 2024
@fl4via fl4via marked this pull request as ready for review October 15, 2024 21:41
@fl4via fl4via requested a review from jasondlee October 15, 2024 21:41
@fl4via fl4via added the next release This PR will be merged before next release or has already been merged (for payload double check) label Oct 15, 2024
@fl4via fl4via removed the waiting CI check Ready to be merged but waiting for CI check label Oct 16, 2024
@fl4via fl4via merged commit 810a653 into undertow-io:main Oct 16, 2024
13 of 16 checks passed
@fl4via fl4via deleted the UNDERTOW-2449_2 branch October 16, 2024 08:36
This was referenced Oct 16, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondlee jasondlee jasondlee approved these changes

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fl4via @jasondlee