Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added profile to pom for creation of unshaded Rascal jar #2111

Merged
merged 6 commits into from
Dec 23, 2024

Conversation

rodinaarssen
Copy link
Member

Since the recent addition of several maven dependencies, rascal-maven-plugin no longer works due to multiple dependency injection errors. This PR adds a maven profile for rascal that produces an unshaded jar/pom, which removes unintended dependency injection.

Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we should also add it to our build.yaml file, so that we do a deploy of the regular and one for the -P unshaded version?

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@DavyLandman DavyLandman marked this pull request as ready for review December 23, 2024 13:09
@DavyLandman DavyLandman changed the base branch from dependency-update to main December 23, 2024 13:10
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49%. Comparing base (e456420) to head (6291db5).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2111   +/-   ##
=======================================
- Coverage       49%     49%   -1%     
- Complexity    6347    6348    +1     
=======================================
  Files          667     667           
  Lines        59836   59836           
  Branches      8692    8692           
=======================================
- Hits         29732   29725    -7     
- Misses       27854   27858    +4     
- Partials      2250    2253    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodinaarssen rodinaarssen merged commit bc98818 into main Dec 23, 2024
7 checks passed
@rodinaarssen rodinaarssen deleted the unshaded-jar-configuration branch December 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants